Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX transfer learning bug #218

Merged
merged 8 commits into from
Jun 13, 2024
Merged

FIX transfer learning bug #218

merged 8 commits into from
Jun 13, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jun 10, 2024 •
edited
Loading

This PR fixes two bugs during transfer learning:

  • I modified a method argument in place which is a global variable in python
  • Decoys are now removed from the transfer learning dataset

@GeorgWa GeorgWa added the test:e2e End to end tests will be run on PRs that carry this label. label Jun 10, 2024
@GeorgWa GeorgWa changed the title FIX transferlearning bug FIX transfer learning bug Jun 10, 2024
@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Jun 10, 2024
mschwoer
mschwoer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
mschwoer
mschwoer requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove mutable arguments where they caused issues

alphadia/workflow/peptidecentric.py Outdated Show resolved Hide resolved
@GeorgWa GeorgWa requested a review from mschwoer June 12, 2024 21:04
@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Jun 12, 2024
@GeorgWa GeorgWa marked this pull request as ready for review June 13, 2024 00:38
mschwoer
mschwoer approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/workflow/peptidecentric.py Show resolved Hide resolved
mo-sameh
mo-sameh approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@mo-sameh mo-sameh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgWa GeorgWa merged commit 9f6ad24 into development Jun 13, 2024
7 checks passed
@GeorgWa GeorgWa deleted the fix-tl-bug branch June 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@mo-sameh mo-sameh mo-sameh approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgWa @mo-sameh @mschwoer