Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT Set log level from config #215

Merged
merged 3 commits into from
Jun 13, 2024
Merged

FEAT Set log level from config #215

merged 3 commits into from
Jun 13, 2024

Conversation

GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Jun 10, 2024 •
edited
Loading

Allows setting log level from config.
Please review #216 first.

@GeorgWa GeorgWa requested review from mschwoer and jalew188 June 10, 2024 18:26
@GeorgWa GeorgWa marked this pull request as ready for review June 10, 2024 18:26
@GeorgWa GeorgWa added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Jun 10, 2024
@GeorgWa GeorgWa requested a review from mo-sameh June 11, 2024 15:50
@mschwoer mschwoer changed the base branch from development to raw-file-stats June 12, 2024 07:57
mschwoer
mschwoer approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs good to me!

alphadia/workflow/reporting.py Show resolved Hide resolved
alphadia/planning.py Outdated Show resolved Hide resolved
Base automatically changed from raw-file-stats to development June 12, 2024 19:52
@GeorgWa GeorgWa merged commit 7350896 into development Jun 13, 2024
3 checks passed
@GeorgWa GeorgWa deleted the set-log-level branch June 13, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschwoer mschwoer mschwoer approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

@mo-sameh mo-sameh Awaiting requested review from mo-sameh

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgWa @mschwoer