Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional diann fdr #284

Closed
wants to merge 4 commits into from
Closed

Additional diann fdr #284

wants to merge 4 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Jan 21, 2025 •
edited
Loading

Add additional filtering for DIANN.

This should now be equivalent to bm_tools.diann.pivot_quan_table

Missing:

  • moving FDR check up the hierarchy
  • switches for first & second search

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mschwoer mschwoer changed the base branch from main to development January 21, 2025 12:53
@mschwoer mschwoer changed the base branch from development to add_anndata_factory January 21, 2025 12:53
@mschwoer mschwoer marked this pull request as draft January 21, 2025 14:16
@mschwoer mschwoer closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

@vbrennsteiner vbrennsteiner Awaiting requested review from vbrennsteiner

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mschwoer