Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce ModifiedSequenceReader #253

Closed
wants to merge 19 commits into from
Closed

introduce ModifiedSequenceReader #253

wants to merge 19 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Nov 22, 2024 •
edited
Loading

  • simplifying the inheritance structure and avoid overwriting superclass methods with pass
  • get rid of obsolete checks on empty origin_df
  • get rid of _transform_table
  • drop hardcoding of "EG.PrecursorId"
  • move test_data_downloader.py to tools/data_downloader.py

@mschwoer mschwoer marked this pull request as ready for review November 22, 2024 09:05
@GeorgWa
Copy link
Collaborator

GeorgWa commented Nov 22, 2024

Should we maybe change the naming to modified sequence reader?

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

GeorgWa
GeorgWa approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to understand it as good as possible. And it mostly looked like cleanup/smaller refactoring. LGTM

@mschwoer mschwoer closed this Nov 26, 2024
@mschwoer mschwoer reopened this Nov 26, 2024
@mschwoer mschwoer changed the title introduce MaxQuantLikeReader introduce ModifiedSequenceReader Nov 26, 2024
@mschwoer mschwoer changed the base branch from refactor_readers_X to refactor_readers_VIII November 26, 2024 09:23
@mschwoer mschwoer changed the base branch from refactor_readers_VIII to refactor_readers_X November 26, 2024 09:23
@mschwoer mschwoer closed this Nov 26, 2024
@mschwoer mschwoer mentioned this pull request Nov 26, 2024
Open
@mschwoer
Copy link
Contributor Author

see #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@jalew188 jalew188 Awaiting requested review from jalew188

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa