-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require an @
in front of all commands.
#261
Conversation
I could put the |
Can we not require it yet? Behind a config is preferred if we are hoping to require it. |
Done, this PR should not affect any users, except those who exhaustively construct/destruct |
I guess that still technically counts as a breaking change. But clippy can update to a git rev temporarily. |
The failing test is unrelated to this change. Will you release a new version, @Manishearth? |
Needs to be a major bump yeah? Will do. |
Published v0.10.0 Hopefully one of the last publishes of this crate since I'd like to point people towards uitest over time. |
Yeah. Perhaps we should consider deprecating/archiving and pointing to uitest in the README at some point. |
Update to a compiletest-rs version that requires `//@` for commands Requires Manishearth/compiletest-rs#261 to get published This PR is a smaller step towards #10426 changelog: Move to a version of compiletest-rs that allows us to require `//`@`` for test suite commands.
This paves the way for actually implementing rust-lang/compiler-team#512 and thus checking that the commands actually parse and aren't silently ignored.
It also is an intermediate step in rust-lang/rust-clippy#10426 for moving to the
ui_test
crate