Fix wrong value of MObject width/height with empty VGroup #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvauvert
commented
Jan 3, 2025
| @@ -136,21 +136,19 @@ def test_mobject_dimensions_nested_mobjects(): | |||
|
|
|||
|
|
|||
| def test_mobject_dimensions_mobjects_with_no_points_are_at_origin(): | |||
There was a problem hiding this comment.
As the previous test was testing an unexpected behavior, it should have been linked to an issue.
gvauvert
commented
Jan 3, 2025
| @@ -2149,10 +2153,11 @@ def get_nadir(self) -> Point3D: | |||
|
|
|||
| def length_over_dim(self, dim: int) -> float: | |||
There was a problem hiding this comment.
As this function is meant to be used only internally, it should be private
Suggested change
| def length_over_dim(self, dim: int) -> float: | |
| def __length_over_dim(self, dim: int) -> float: |
or at least protected
Suggested change
| def length_over_dim(self, dim: int) -> float: | |
| def _length_over_dim(self, dim: int) -> float: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix the issue 4087.
When an MObject contains an empty VGroup, its width or height can be wrong
Motivation and Explanation: Why and how do your changes improve the library?
Bug fix + tests
Links to added or changed documentation pages
No documentation page, bug fix only.
Further Information and Comments
Reviewer Checklist