Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan fixes (php doc blocks) #643

Merged
merged 3 commits into from
Nov 12, 2024
Merged

phpstan fixes (php doc blocks) #643

merged 3 commits into from
Nov 12, 2024

Conversation

williamdes
Copy link
Contributor

No description provided.

@williamdes
Copy link
Contributor Author

@fredericdelordm some basic fixes

@williamdes
Copy link
Contributor Author

What do you think about this @iulian03

iulian03
iulian03 reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@iulian03 iulian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I've added a single comment.

@williamdes
Copy link
Contributor Author

Looking good. I've added a single comment.

Thanks, I removed it.
That said, it was important for phpstan analysis since it can not figure out what type is the object.

@williamdes williamdes requested a review from iulian03 July 10, 2024 08:59
@williamdes
Copy link
Contributor Author

Hi @iulian03
Does this PR look okay now ?

@iulian03 iulian03 merged commit 7aad50d into Mangopay:master Nov 12, 2024
0 of 4 checks passed
@williamdes williamdes deleted the phpstan-fixes branch November 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulian03 iulian03 iulian03 approved these changes

@mralaminahamed mralaminahamed mralaminahamed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamdes @mralaminahamed @iulian03