Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CardId property to PayInExecutionDetailsDirect and used “int” as types for identifiers #563

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

garsaud
Copy link
Contributor

@garsaud garsaud commented Jul 13, 2022

To help with autocompletion and code scanning tools like Phpstan

@fredericdelordm
Copy link
Contributor

Hello @garsaud,

Thank you for the PR. We are looking into it.

@garsaud garsaud changed the title Added CardId property to PayInExecutionDetailsDirect Added CardId property to PayInExecutionDetailsDirect and used “int” as types for identifiers Oct 18, 2022
@garsaud garsaud force-pushed the patch-1 branch 2 times, most recently from 28f36ce to a6ea7cf Compare October 18, 2022 09:54
@iulian03
Copy link
Contributor

@garsaud please update your PR with the latest version of master in order to merge. Thanks!

@garsaud
Copy link
Contributor Author

garsaud commented Oct 18, 2022

@iulian03 Master branch is still causing CI failures, because 35e3910 is not merged yet

@iulian03
Copy link
Contributor

@garsaud we've just merged a PR that should fix all tests. Please update your PR again with the master branch, thanks! Sorry you had to do it twice :)

@garsaud garsaud force-pushed the patch-1 branch 2 times, most recently from 32f6aa0 to 5de2656 Compare October 18, 2022 14:30
@garsaud
Copy link
Contributor Author

garsaud commented Oct 25, 2022

@iulian03 Is it all good now? 🙂

@iulian03 iulian03 merged commit 61a9b23 into Mangopay:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants