-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Replace Handsoap with RbVmomi #103
base: master
Are you sure you want to change the base?
Conversation
e1861f4
to
0b1023b
Compare
0b1023b
to
2434901
Compare
I saw the issue title and assumed it was done ...I got so excited haha |
@agrare Will this ultimately remove the wsdl file as well? |
Yes 😀 |
b765c33
to
e797cbe
Compare
If we will iterate a bunch on this, would it make sense to not remove wsdl definitions in this PR? |
@jrafanie @chessbyte Take a look at all the 🔴 😍 |
You don't get to see this kind of bottomline often: Most of it's yaml but who cares, this is awesome! |
725adcb
to
a3cac4f
Compare
41d2894
to
a5262ac
Compare
8a6c078
to
6d66f2d
Compare
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
2231338
to
3570496
Compare
Checked commits agrare/vmware_web_service@e1d1449~...3570496 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint **
lib/VMwareWebService/MiqVimClientBase.rb
lib/VMwareWebService/VimService.rb
|
This pull request is not mergeable. Please rebase and repush. |
TODO: