Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace Handsoap with RbVmomi #103

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Apr 13, 2021

TODO:

  • Retrieve Service Content
  • Login/Logout
  • Convert all methods in VimService
  • Convert monitorUpdates
  • Convert from RbVmomi types to VimTypes for compatibility

@agrare agrare requested a review from Fryguy as a code owner April 13, 2021 16:37
@agrare agrare added the wip label Apr 13, 2021
@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from e1861f4 to 0b1023b Compare April 14, 2021 12:57
@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from 0b1023b to 2434901 Compare April 14, 2021 13:34
@Fryguy
Copy link
Member

Fryguy commented Apr 14, 2021

I saw the issue title and assumed it was done ...I got so excited haha

@Fryguy
Copy link
Member

Fryguy commented Apr 14, 2021

@agrare Will this ultimately remove the wsdl file as well?

@agrare
Copy link
Member Author

agrare commented Apr 14, 2021

Will this ultimately remove the wsdl file as well?

Yes 😀

@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from b765c33 to e797cbe Compare April 14, 2021 20:53
@kbrock
Copy link
Member

kbrock commented Apr 16, 2021

If we will iterate a bunch on this, would it make sense to not remove wsdl definitions in this PR?
Github is so excited about these changes that it basically breaks down in excitement.
OTOH/ If this is close to done, lets get you good stats with this PR. currently: +648/ −204,671

@Fryguy
Copy link
Member

Fryguy commented Apr 16, 2021

@jrafanie @chessbyte Take a look at all the 🔴 😍

@jrafanie
Copy link
Member

@jrafanie @chessbyte Take a look at all the 🔴 😍

You don't get to see this kind of bottomline often:
+648 −204,671

Most of it's yaml but who cares, this is awesome!

@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from 725adcb to a3cac4f Compare May 14, 2021 19:31
@agrare agrare force-pushed the replace_handsoap_rbvmomi branch 2 times, most recently from 41d2894 to a5262ac Compare July 13, 2021 19:48
@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from 8a6c078 to 6d66f2d Compare July 14, 2021 15:07
@miq-bot miq-bot added the stale label Feb 27, 2023
@miq-bot miq-bot closed this Feb 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@agrare agrare reopened this Feb 27, 2023
@agrare agrare added pinned and removed stale labels Feb 27, 2023
@agrare agrare force-pushed the replace_handsoap_rbvmomi branch from 2231338 to 3570496 Compare March 3, 2023 17:15
@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2023

Checked commits agrare/vmware_web_service@e1d1449~...3570496 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4193 files checked, 14 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

lib/VMwareWebService/MiqVimClientBase.rb

lib/VMwareWebService/VimService.rb

@miq-bot
Copy link
Member

miq-bot commented May 4, 2023

This pull request is not mergeable. Please rebase and repush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants