Use _.isNaN for integer required validation instead of _.isEmpty #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
BZ1740899-fix-required-integer-value
branch
2 times, most recently
from
0fa6710 to
16fab43
Compare
|
Cool, I think we need this to go back to hammer? |
eclarizio
force-pushed
the
BZ1740899-fix-required-integer-value
branch
from
16fab43 to
f7ff2cb
Compare
|
@miq-bot add_label hammer/yes |
d-m-u
approved these changes
Aug 28, 2019
|
@miq-bot add_label ivanchuk/yes, bug |
|
@d-m-u Cannot apply the following label because they are not recognized: dialog_user |
eclarizio
force-pushed
the
BZ1740899-fix-required-integer-value
branch
from
f7ff2cb to
7977073
Compare
|
Checked commit eclarizio@7977073 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Sep 3, 2019
…-value Use _.isNaN for integer required validation instead of _.isEmpty (cherry picked from commit 485efda) https://bugzilla.redhat.com/show_bug.cgi?id=1748455
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Sep 3, 2019
…-value Use _.isNaN for integer required validation instead of _.isEmpty (cherry picked from commit 485efda) https://bugzilla.redhat.com/show_bug.cgi?id=1740899
|
Ivanchuk backport details: |
This was referenced Sep 4, 2019
This was referenced Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining if a field has a value filled out, when the
data_typeis integer, we're still attempting to do a_.isEmptycheck, which will always fail for integers since they are not an enumerable type. Instead, we should use_.isNaNfor integers. Alternatively we could refactor this into our own_.isBlankand use that instead, but for now this fixes the problem.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740899
@miq-bot assign @h-kataria
@h-kataria @d-m-u Please Review since @himdel is on PTO.