Dialog editor: Make "Load Values on Init" independent of "Show Refresh Button"

[himdel]

Depends on:

• schema: Dialog field - set load_values_on_init to true where show_refresh_button was not enabled manageiq-schema#357 (merged)
• core: Dialog fields - make load_values_on_init independent of show_refresh_button manageiq#18600 (merged)

Dynamic dialog fields can load on init (once), by manually triggering a refresh button, or from "fields to refresh".

Before, when there was no refresh button, load on init was hardcoded to true on the model side and the switch was hidden.

This makes the "Load Values on Init" switch always visible, independent of "Show Refresh Button".

https://bugzilla.redhat.com/show_bug.cgi?id=1684575

[himdel]

Cc @gmcculloug, @eclarizio ... an alternative to this would be to allow the user to actually disable both switches (so, no refresh button, and no loading on init), but I'm not sure how useful that would be.

(And would depend on backend changes, because...

app/models/dialog_field_sorted_item.rb
159-  def load_values_on_init?
160:    return true unless show_refresh_button
161-    load_values_on_init
162-  end

app/models/dialog_field_text_box.rb
88-  def load_values_on_init?
89:    return true unless show_refresh_button
90-    load_values_on_init
91-  end

)

EDIT: (this was written back when I tried to only show the switch, not making it possible to change)

[himdel]

EDIT: oh, never mind, turns out this is useful when you only want the field to update from "fields to refresh"

@miq-bot add_label wip

[himdel]

@miq-bot remove_label wip

(but dependencies)

[himdel]

@miq-bot add_label wip

TODO: make sure the default values still make sense

[miq-bot]

Checked commits https://github.com/himdel/ui-components/compare/114c60d16d2811acdf92df227d20222fc975f5ec~...3f98c7f91f7d26c4256b371918adfdacc2fd8566 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

@miq-bot remove_label wip

New fields should get load_values_on_init set to true by default.

[himdel]

@miq-bot add_label hammer/no

(because ManageIQ/manageiq-schema#357 (comment))