Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower cleanup #349

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Bower cleanup #349

merged 1 commit into from
Oct 16, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Oct 5, 2018

This PR removes any bower support and references.

It also changes what happens on PR merge:

  • before, the bower-dev branch was updated with the current state
  • now, the bower-dev branch will stay on the last version used by ui-classic via bower (already added a notice to the readme there) and ui-classic will use current npm version

(related to ManageIQ/manageiq-ui-classic#4694 and ManageIQ/manageiq-ui-classic#4735 but does not depend on either)

removes most bower references

(and removes eslintrc lines that were never relevant for ui-components, only ui-classic)
@himdel
Copy link
Contributor Author

himdel commented Oct 5, 2018

Cc @romanblanco, @eclarizio, @chalettu, @skateman (because you're the ones who usually fix stuff here)

This change would mean that you may need to update the @manageiq/ui-components dependency in ui-classic and ui-service manually, as it will no longer follow master.

Any issues with that?

@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commit https://github.com/himdel/ui-components/commit/952ff38e73bf5444994b4f9c95586327efebd75f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@skateman
Copy link
Member

skateman commented Oct 8, 2018

Hmm...seems okay to me, good job 👍

@eclarizio
Copy link
Member

@himdel Seems fine to me, can we put instructions on how to update the dependency manually here/somewhere for reference? I'm pretty sure it's just a symlink, but I did mine a long time ago and don't remember if there are other steps.

@himdel
Copy link
Contributor Author

himdel commented Oct 9, 2018

Oh, once a PR is merged (and autorelease (#351) is working), you will just need a yarn add @manageiq/ui-components in the right repo to upgrade to the current version.

For development there's yarn link, added both to https://github.com/ManageIQ/ui-components/wiki :).

@Fryguy Fryguy merged commit 4e1eb30 into ManageIQ:master Oct 16, 2018
@himdel himdel deleted the bower-cleanup branch October 16, 2018 13:29
@Fryguy Fryguy added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 16, 2018
@Fryguy Fryguy self-assigned this Oct 16, 2018
simaishi pushed a commit that referenced this pull request Oct 17, 2018
Bower cleanup

(cherry picked from commit 4e1eb30)
@simaishi
Copy link

Hammer backport details:

$ git log -1
commit a297544662d70691a3d2b8a84a8b1df0b346b7e7
Author: Jason Frey <[email protected]>
Date:   Tue Oct 16 09:29:06 2018 -0400

    Merge pull request #349 from himdel/bower-cleanup
    
    Bower cleanup
    
    (cherry picked from commit 4e1eb302a99cac84bccaa15a55d195653e4849cc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants