-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bower cleanup #349
Bower cleanup #349
Conversation
removes most bower references (and removes eslintrc lines that were never relevant for ui-components, only ui-classic)
Cc @romanblanco, @eclarizio, @chalettu, @skateman (because you're the ones who usually fix stuff here) This change would mean that you may need to update the Any issues with that? |
Checked commit https://github.com/himdel/ui-components/commit/952ff38e73bf5444994b4f9c95586327efebd75f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
Hmm...seems okay to me, good job 👍 |
@himdel Seems fine to me, can we put instructions on how to update the dependency manually here/somewhere for reference? I'm pretty sure it's just a symlink, but I did mine a long time ago and don't remember if there are other steps. |
Oh, once a PR is merged (and autorelease (#351) is working), you will just need a For development there's |
Bower cleanup (cherry picked from commit 4e1eb30)
Hammer backport details:
|
This PR removes any bower support and references.
It also changes what happens on PR merge:
bower-dev
branch was updated with the current statebower-dev
branch will stay on the last version used by ui-classic via bower (already added a notice to the readme there) and ui-classic will use current npm version(related to ManageIQ/manageiq-ui-classic#4694 and ManageIQ/manageiq-ui-classic#4735 but does not depend on either)