-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ng-change for tag control options #253
Set ng-change for tag control options #253
Conversation
@miq-bot assign @eclarizio @miq-bot add_label blocker |
cc - @gmcculloug |
@miq-bot add_labels bug, gaprindashvili/yes |
@eclarizio - Please review |
63df951
to
1409a55
Compare
Create a function setupCategoryOptions to be called on ng-change https://bugzilla.redhat.com/show_bug.cgi?id=1542590
1409a55
to
8d68195
Compare
Checked commit syncrou@8d68195 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a bit of background for @himdel: before, all of the category information (id, name, description) was being passed through the API to the core repo when editing a TagControl field, but because the core repo was looking up the category by name and not ID, it wasn't actually changing the category.
Now, @syncrou made a change to the core repo to take all 3 properties into account, and so when selecting from the drop-down, we needed a way to update all 3.
👍
@romanblanco You may want to review this as well, figured I'd tag you since it's in the dialog editor section. |
the mentioned change - ManageIQ/manageiq#16965 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Is this blocker PR ready to merge? |
@himdel @karelhala can you merge? |
Backported to
|
Set ng-change for tag control options (cherry picked from commit c07afbc)
Released in 1.0.13 and 1.1.5. |
Create a function setupCategoryOptions to be called on ng-change
Gigantic Thank you to @eclarizio for all his help!
https://bugzilla.redhat.com/show_bug.cgi?id=1542590