Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prs_per_repo script should optimize interactions with GitHub #48

Conversation

chessbyte
Copy link
Member

By using GitHub search

@chessbyte chessbyte force-pushed the prs_per_repo_should_optimize_interactions_with_github branch from b4446f5 to 6e36abd Compare May 4, 2020 18:06
@chessbyte chessbyte requested review from bdunne and Fryguy May 4, 2020 19:14
@chessbyte
Copy link
Member Author

I think that most of the logic of getting PRs for a particular sprint or set of sprints should be pushed back into the SprintStatisics class (or something named more appropriately). This would make the SprintStatistics class the single communicator with GitHub and, thereby, the single source of truth for all the other data massaging.

@Fryguy Fryguy merged commit def1604 into ManageIQ:master May 4, 2020
@Fryguy
Copy link
Member

Fryguy commented May 4, 2020

I think that most of the logic of getting PRs for a particular sprint or set of sprints should be pushed back into the SprintStatisics class (or something named more appropriately). This would make the SprintStatistics class the single communicator with GitHub and, thereby, the single source of truth for all the other data massaging.

I think we need to look at our multiple repos and maybe come up with something to bring then all together. This repo is starting to resemble managiq-release which is my go to repo for anything that calls out to github/git for meta reasons. As such, I'd like to avoid duplicating effort across them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants