View button responsiveness fix

[epwinchell]

The PR adds in the missing "toolbar-pf-action-right" class div, which makes the view buttons align left when in the responsive state.

Before (demo)

After (demo)

Before (ui classic)

After (ui classic)

[epwinchell]

@miq-bot assign @martinpovolny

[epwinchell]

@miq-bot bug, cleanup

[miq-bot]

@epwinchell unrecognized command 'bug', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone

[miq-bot]

Checked commit https://github.com/epwinchell/react-ui-components/commit/e42d78292126bc1b535ef0d54d62dd295ff757b6 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[karelhala]

🎉 This PR is included in version 0.11.56 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[himdel]

@martinpovolny We really need to fix the jest bits, this also breaks ui travis :)

 FAIL  app/javascript/spec/toolbar/miq-toolbar.spec.jsx
  ● <MiqToolbar /> › renders ok for generic case
    expect(received).toMatchSnapshot()
    Snapshot name: `<MiqToolbar /> renders ok for generic case 1`
    - Snapshot
    + Received
    @@ -86,11 +86,15 @@
            <ToolbarView
              onClick={[Function]}
              views={Array []}
            >
              <div
    -           className="toolbar-pf-view-selector pull-right form-group"
    -         />
    +           className="toolbar-pf-action-right"
    +         >
    +           <div
    +             className="form-group toolbar-pf-view-selector"
    +           />
    +         </div>
            </ToolbarView>
          </div>
        </Toolbar>
      </MiqToolbar>

(regenerating the snapshot for now - ManageIQ/manageiq-ui-classic#6418)

[martinpovolny]

Oh you fixed it already.

[martinpovolny]

The problem here is that I have to get the change merged to get the bot do a release.

After that, I can update the UI classic.

But at that point the test is already broken.

I think that what is needed here is remove the snapshot test from the UI classic (or move it here) and do a different type of test (w/o a snapshot) on UI classic side.

WDYT?

[martinpovolny]

Btw, on top of thanking @himdel for quickly fixing this I also thank @Fryguy for quickly merging the fix ;-)

[himdel]

Yup, either we should think about some way of getting the react-ui-components release (and ui-components) trigger a push to ui-classic (and ui-service) master, to use the new version right away,

or we can't do snapshot tests across repo boundaries.

Or both :).

I think there should be a way of telling jest "these are our components, expand them by default, but those are from elsewhere, stop at those".