Merge pull request #86 from PanSpagetka/tagging-pf4fix-props-validation

Fix PropTypes validation from PF4 tagging
ManageIQ · Oct 1, 2018 · 75c6bf1 · 75c6bf1
2 parents 749df25 + f642b7b
commit 75c6bf1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/tagging-pf4/components/BadgeWithDelete.js b/src/tagging-pf4/components/BadgeWithDelete.js
@@ -2,7 +2,6 @@ import * as React from 'react';
 import PropTypes from 'prop-types';
 import { Badge } from '@patternfly/react-core';
 import { TimesIcon } from '@patternfly/react-icons';
-import TaggingPropTypes from '../TaggingPropTypes';
 
 const BadgeWithDelete = ({
   onDeleteClick, description, truncate, className,
@@ -24,8 +23,8 @@ const BadgeWithDelete = ({
 );
 
 BadgeWithDelete.propTypes = {
-  onDeleteClick: PropTypes.func.isRequired,
-  description: TaggingPropTypes.string,
+  onDeleteClick: PropTypes.func,
+  description: PropTypes.string,
   truncate: PropTypes.func,
   className: PropTypes.string,
 };

diff --git a/src/tagging-pf4/components/Tag.js b/src/tagging-pf4/components/Tag.js
@@ -16,7 +16,7 @@ const Tag = ({
 );
 
 Tag.propTypes = {
-  onTagDeleteClick: PropTypes.func.isRequired,
+  onTagDeleteClick: PropTypes.func,
   tagValue: TaggingPropTypes.value,
   truncate: PropTypes.func.isRequired,
 };

diff --git a/src/tagging-pf4/components/TagCategory.js b/src/tagging-pf4/components/TagCategory.js
@@ -34,7 +34,7 @@ class TagCategory extends React.Component {
 
 TagCategory.propTypes = {
   onTagDeleteClick: PropTypes.func,
-  tagCategory: TaggingPropTypes.category.isRequired,
+  tagCategory: TaggingPropTypes.category,
   values: PropTypes.arrayOf(TaggingPropTypes.category).isRequired,
   categoryTruncate: PropTypes.func,
   valueTruncate: PropTypes.func,