Refactor constraints #156
Refactor constraints #156
Conversation
|
Realized I did not update the documentation, but would like to get feedback on this so moving to draft |
This was also my only concern here. It also takes away from what might be other use cases for validation. For example, we might want to allow similar things to what activerecord validation provides, such as :format or :comparison. That is I could see something like: opt :max_volume, :type => :integer
opt :start_volume, :type => :integer
validates :start_volume, comparison: { less_than_or_equal_to: :max_volume }So I think the way forward is give a more clear name for the minmax, but that will likely hold up the refactoring. I'd be ok with a separate PR with just the refactorting, since that's much clearer and I'm basically ready to merge now, and then the mixmax bit can be a smaller PR. I'm still not sure of a realistic use case is for mix max, which makes it a little harder for me to understand. |
nanobowers
force-pushed
the
refactor_constraints
branch
from
9ce021f to
b5e5d7d
Compare
|
Reverted this to a plain old refactoring of the depend/conflict/either constraints. Can tackle min/max validation in another PR. |
|
I'm surprised that no specs failed with the changes in wording. Are these tested? |
No, apparently not. The difference in the algorithm for determining success/failure of the Constraints would make it impractical to match the old failure messages. Should I put together some tests for the failure messages before closing out this PR? |
Yes, please - even a few basic tests would be sufficient. |
nanobowers
force-pushed
the
refactor_constraints
branch
from
b5ad3b3 to
80d2980
Compare
Added: - Align the short and long forms into their own columns in the help output (#145 - thanks akhoury6) - Add support for DidYouMean when long options are spelled incorrectly (#150 - thanks nanobowers) - Using `permitted:` restricts the allowed values that a end-user inputs to a pre-defined list (#147 - thanks akhoury6) - Add exact_match to settings, defaulting to inexact matching (#154 - thanks nanobowers) - Add setting to disable implicit short options (#155 - thanks nanobowers) - Add alt longname and multiple char support (#151 - thanks nanobowers) - Permitted regexp/range support (#158, #159- thanks nanobowers) - Add some examples (#161 - thanks nanobowers) Changed: - Enable frozen_string_literal for future-ruby support (#149, #153 - thanks nanobowers) - Refactor constraints (#156 - thanks nanobowers) - Fix assert_raises to assert_raises_errmatch (#160 - thanks nanobowers)
DependConstraint,ConflictConstraint,EitherConstraint) with an abstractConstraintclass.Addvalidatemethod which points to newMinMaxConstraint, plus tests.tbh i'm not too sure about thevalidatename, the name feels a little unclear about its purpose to me.@miq-bot add-label refactoring
@miq-bot add-reviewer @Fryguy