Reset of the default automate domains #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise "#{MANAGEIQ_DOMAIN} domain directory not found [#{ds_dir}]" unless Dir.exist?(ds_dir) | ||
| reset_manageiq_domain(ds_dir) | ||
| raise "Datastore directory [#{ds_dir}] not found" unless Dir.exist?(ds_dir) | ||
| Dir.glob("#{ds_dir}/*/#{DOMAIN_YAML_FILENAME}").each do |domain_file| |
There was a problem hiding this comment.
@mkanoor Looks like you are including MiqAeYamlImportExportMixin at the top of this file to resolve the DOMAIN_YAML_FILENAME constant. I think it would be better to remove the include and fully qualify the reference using MiqAeDomain::DOMAIN_YAML_FILENAME.
The rake script was broken looking for 'datastore' directory Added support for resetting multiple domains if they exist in the db/fixtures/ae_datastore directory
|
Checked commit mkanoor@09237b2 with rubocop 0.21.0 |
|
@gmcculloug |
gmcculloug
added a commit
that referenced
this pull request
Jun 27, 2014
Reset of the default automate domains
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Aug 31, 2017
Skip invalid container_images (cherry picked from commit f006a2572c257c8545aa29bfa621688b404e76e0)
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Sep 22, 2017
Skip invalid container_images (cherry picked from commit f006a2572c257c8545aa29bfa621688b404e76e0)
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Sep 22, 2017
Skip invalid container_images (cherry picked from commit f006a2572c257c8545aa29bfa621688b404e76e0)
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Skip invalid container_images (cherry picked from commit f006a2572c257c8545aa29bfa621688b404e76e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rake script was broken looking for 'datastore' directory
Added support for resetting multiple domains if they exist in
the db/fixtures/ae_datastore directory