Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamlit updated to v2.7.0 #9167

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Hamlit updated to v2.7.0 #9167

merged 1 commit into from
Sep 27, 2016

Conversation

skateman
Copy link
Member

@skateman skateman commented Jun 9, 2016

The hamlit-rails is not maintained at all and we don't need the provided generators at all.

@skateman
Copy link
Member Author

skateman commented Jun 9, 2016

@AparnaKarve the failing tests (e.g f8e9538 ) were introduced by you and I don't think that the include is the best idea to match DOM-related stuff. I was trying to rewrite them to have_selector matchers, but I'm not familiar with that enough. Could you please help me? I'm also open for other solutions!

@AparnaKarve
Copy link
Contributor

I don't think that the include is the best idea to match DOM-related stuff

@skateman I agree, it's not. Will figure out a better way to test that.

@miq-bot
Copy link
Member

miq-bot commented Jul 8, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@skateman skateman changed the title Hamlit updated to v2.5.0 Hamlit updated to v2.7.0 Sep 16, 2016
@miq-bot
Copy link
Member

miq-bot commented Sep 16, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@skateman
Hamlit updated to v2.7.0
2acf8d1 
The hamlit-rails is not maintained at all and we don't need the provided generators at all.
@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2016

Checked commit skateman@2acf8d1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 1 offense detected

spec/support/view_spec_helper.rb

@skateman
Copy link
Member Author

skateman commented Sep 23, 2016 •
edited
Loading

@dclarizio i think this is good to go, but someone should review

@dclarizio
Copy link

@AparnaKarve please review and/or suggest others to review .. . Thx, Dan

@AparnaKarve
Copy link
Contributor

@skateman The test that you pointed above (f8e9538) ... is that not an issue anymore?
What changed?

@skateman
Copy link
Member Author

@AparnaKarve the version of haml-lint and the way how we require it.

@AparnaKarve
Copy link
Contributor

@dclarizio This is good to merge.

@skateman
Copy link
Member Author

:shipit:

@dclarizio dclarizio merged commit 1b16fbd into ManageIQ:master Sep 27, 2016
@dclarizio dclarizio added this to the Sprint 47 Ending Oct 3, 2016 milestone Sep 27, 2016
chessbyte pushed a commit that referenced this pull request Sep 29, 2016
@chessbyte
Merge pull request #9167 from skateman/hamlit-update-2.5
2b590e2 
Hamlit updated to v2.7.0
(cherry picked from commit 1b16fbd)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log
commit 2b590e26b6afba92a8e6920840ec082753f417bd
Author: Dan Clarizio <[email protected]>
Date:   Tue Sep 27 14:15:20 2016 -0700

    Merge pull request #9167 from skateman/hamlit-update-2.5

    Hamlit updated to v2.7.0
    (cherry picked from commit 1b16fbda4e9c7a2f0317db7ba4d10f0719799b52)

@skateman skateman deleted the hamlit-update-2.5 branch September 30, 2016 07:56
@jrafanie jrafanie mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
dependencies euwe/backported technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @AparnaKarve @miq-bot @dclarizio @chessbyte