Add another stub for Entitlement for preventing to load from app folder in migration

[lpichler]

#6739

this change is allowing to use https://github.com/testdouble/good-migrations
and prevents to load Entitlement model from app folder

@jrafanie @Fryguy @chrisarcand

[jrafanie]

Good find @lpichler 👍

[chrisarcand]

Wait the reason you added a second entitlement in this order is because
Rails auto loads the class via the association as soon as the model is
defined? Is that right?

On Tuesday, April 5, 2016, Joe Rafaniello [email protected] wrote:

Good find @lpichler https://github.com/lpichler [image: 👍]

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#7729 (comment)

Chris Arcand
@chrisarcand

[lpichler]

@chrisarcand yes exaclty but this is valid when you are using definition with class

has_one :entitlement, :class_name => RemoveMiqUserRoleFromMiqGroups::Entitlement

but when you use it in quotes

has_one :entitlement, :class_name => 'RemoveMiqUserRoleFromMiqGroups::Entitlement'

it seems that is not loading the class 'RemoveMiqUserRoleFromMiqGroups::Entitlement' for this case even when I deleted model entitlement.rb => good_migration gem was silent and be db:migrate ran succesfully

(I am not sure what are exact differences in these cases when sql is generated or how impact it has, if any)

@jrafanie @Fryguy
so should I rather use it in quotas ? (then we can avoid multiple definition of classes in migrations for these cases)

[Fryguy]

I don't think Entitlement should be defined twice like that. I would think that all :class_name should be strings as that's how we do it in other migrations, and don't have a problem.

[chrisarcand]

Ooooh I see. My fault entirely. Yes we should be using strings.

Aside, I hate these sorts of 'flexibility features' :disappointed_eyes:

[miq-bot]

Checked commit lpichler@6b7afbb with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

[lpichler]

ok, strings used, thanks guys 👍

[jrafanie]

👍

[chrisarcand]

👌