Don't load container models from app folder in migration

[lpichler]

for possibility to use good_migration gem

related #6739

change from CONTAINER_TABLES toCONTAINER_MODELSwas needed because this command t.to_s.classify.constantize.update_all` is loading it from app/ folder even if we are defining these models in the migration

this changes have been made by this script

CONTAINER_TABLES = [:container_nodes, :container_projects, :container_services, :container_routes, :container_groups,
                    :container_replicators, :container_quotas, :container_builds, :container_build_pods,
                    :container_limits, :container_volumes]

type_column_exists = lambda { |t| ActiveRecord::Base.connection.column_exists?(t, :type) }
tables = CONTAINER_TABLES.map { |e| [e.to_s.classify.constantize, type_column_exists.call(e)] }
puts tables

tables.each do |t|
  print "\n"
  print "class #{t.first.to_s} < ActiveRecord::Base"
  if t.second
    print "\n"
    print "  self.inheritance_column = :_type_disabled # disable STI\n"
    print "end\n"
  else
    print "; end\n"
  end
end

print "CONTAINER_TABLES =["
CONTAINER_TABLES.each do |t|
  print "#{t.to_s.classify}, "
end

cc @jrafanie @Fryguy

[Fryguy]

@lpichler Is there a spec for this in spec/migrations?

[lpichler]

@Fryguy there is no spec for it, so I will add it to this PR, thanks

[Fryguy]

/me is upset that got merged in the first place without a spec :(

[jrafanie]

This was pre-rails 5, but in new migrations created with rails 5, I believe these should be < ApplicationRecord; end ... Right @matthewd?

[matthewd]

No.

Part of the advantage of ApplicationRecord is that we can leave AR::Base unmolested, which is exactly what migrations want: a plain ordinary AR object with no app-code-of-the-day surprises.

[jrafanie]

Great, thanks!

[Fryguy]

@matthewd That is really interesting and good to know! I didn't even think of that.

[lpichler]

@jrafanie @Fryguy updated, specs added.

thanks @Ladas

[jrafanie]

We probably shouldn't define these methods globally.

[jrafanie]

After you remove the tests for schema changes (columns dropped/added, see below), do we need these methods anymore? Maybe just do the work in-line if it's only a few places.

[lpichler]

yes, it is only on few places now 👍

[miq-bot]

Checked commits lpichler/manageiq@4087231~...ff856e2 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍰

[lpichler]

@jrafanie I removed testing of schema, now it looks simplier, thanks for your feedback!

[coveralls]

Coverage decreased (-0.1%) to 32.274% when pulling ff856e2 on lpichler:dont_reference_containers_models_from_app into c253de1 on ManageIQ:master.