Update Bunny gem

[Ladas]

Update Bunny gem, the old gem couldn't handle reconnect when
amqp service got restarted.

Seems like new bunny works the same, so no changes in using it
are needed.

Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1222005

[miq-bot]

Checked commit Ladas@0effc7c with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0
1 file checked, 0 offenses detected
Everything looks good. 👍

[chessbyte]

@blomquisg please review

[blomquisg]

The only thing that jumped out at me was that after 1.6.0 Bunny now sets verify_peer = true by default, whereas before it was verify_peer = false.

This will only mess us up with situations where the user enables SSL for AMQP. Which, as I understand it, is not a standard configuration for AMQP in OSP.

Still, I think we should play it safe and do the following:

• add a setting to control OpenStack AMQP verify_peer in vmdb.tmpl.yml
  • should we use the same CA as we use for the SSL cert verification of the OSP API?
• default the Bunny verify_peer to false
• add some documentation describing how to install the CA for peer verification if it's different than the OSP API CA.

[matthewd]

default the Bunny verify_peer to false

😟

[Ladas]

@blomquisg hm, but that is for followup PR, right? Because we don't support AMQP SSL at all now.

Then my guess would be that this setting will go to Endpoint data? Yeah, I would use the same CA for now.

[blomquisg]

@matthewd yeah 😞

Alternatively, we could doc it away, since we don't have a better solution that helps users setup the CA cert for OpenStack API and AMQP.

I would think the right thing to do here would be to either (or both) have a page in the Appliance configuration that allows an admin to upload a CA for OpenStack connections in their organization, and/or have a mechanism in the appliance console that allows an admin to specify the same CA.

[Ladas]

we need to use 2.1.0, higher versions are breaking ipv6 ruby-amqp/bunny#383

[miq-bot]

<github_pr_commenter_batch />Some comments on commit Ladas@0b3328d

• Gemfile changes detected. /cc @JPrause @simaishi