Moved Timelines & Utilization buttons to summary screen from list view. #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
containers_controller_fixes
branch
from
a561aaa to
fb53dc2
Compare
h-kataria
force-pushed
the
containers_controller_fixes
branch
2 times, most recently
from
a89e694 to
95b8e2a
Compare
|
@dkorn bump |
|
@h-kataria first, thanks for this refactor! I tested it locally and found two issues:
|
|
@dkorn, i will look at issue 1, 2 is not an issue, that's by design to bring user back to the last node that they were on before browsing to screen out of explorer. |
- Fixed Timelines & Utilization buttons to go thru x_button method similar to all other toolbar buttons and removed any code that is not needed in explorer & show method. - Added spec tests to verify Timelines & Utilization buttons render correct views.
h-kataria
force-pushed
the
containers_controller_fixes
branch
from
95b8e2a to
dfdb14f
Compare
|
Checked commit h-kataria@dfdb14f with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
@dkorn, i looked into you comment 1, that's by design, in all explorer reload button brings user back to the summary screen of the record that you were on before you clicked on any buttons or relationship links etc. See VM explorer for an example. |
|
@h-kataria thanks for looking into my comments. |
dclarizio
pushed a commit
that referenced
this pull request
Dec 16, 2015
Moved Timelines & Utilization buttons to summary screen from list view.
chrisarcand
pushed a commit
to chrisarcand/manageiq
that referenced
this pull request
Dec 18, 2015
Moved Timelines & Utilization buttons to summary screen from list view. - Fixed Timelines & Utilization buttons to go thru x_button method similar to all other toolbar buttons and removed any code that is not needed in explorer & show method. - Added spec tests to verify Timelines & Utilization buttons render correct views. (cherry picked from commit dfdb14f) https://bugzilla.redhat.com/show_bug.cgi?id=1289694 https://bugzilla.redhat.com/show_bug.cgi?id=1287563 @dclarizi please review, this is a clean cherry-pick for ManageIQ#5738 See merge request !634
|
@miq-bot add_label providers/containers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Timelines & Utilization buttons to go thru x_button method similar to all other toolbar buttons and removed any code that is not needed in explorer & show method.
@dkorn please take a look, this PR addresses the issue where Timelines/Utilization buttons were going thru explorer method and were messing up the url, causing an error(that was fixed with a hack https://github.com/ManageIQ/manageiq/blob/master/app/controllers/container_controller.rb#L138 in explorer method) when clicking on nodes in the tree while user is on timelines/C&U screen.