Exclude files with no extension from precompile

[jrafanie]

https://bugzilla.redhat.com/show_bug.cgi?id=1135050

Fixes the issue precompiling assets with sprockets >= 2.4.4:
"Asset logical path has no extension: codemirror-4.2/AUTHORS"

See the reported upstream issue here[1].
The commit that started this issue is here [2].

This has been an issue in many versions of sprockets since v2.4.4:
v2.12.1 v2.12.0 v2.11.1 v2.11.0 v2.10.1 v2.10.0 v2.9.3 v2.9.2 v2.9.1 v2.9.0 v2.8.2 v2.8.1 v2.8.0 v2.7.0 v2.6.0 v2.5.0 v2.4.5 v2.4.4

The solutions found in [1] were to either:
a) rename assets to add a file extension (such as AUTHORS -> AUTHORS.txt)
b) modify the config.assets.precompile Proc to whitelist which file extensions that were desired or to exclude files without an extension.

[1] sstephenson/sprockets#347
[2] sstephenson/sprockets@5dbd7c6

[jrafanie]

Note: codemirror has many files with no extension that cause sprockets 2.4.4+ to break during asset precompilation:

# find app/assets -type f ! -name "*.*"
app/assets/javascripts/codemirror-4.2/AUTHORS
app/assets/javascripts/codemirror-4.2/bin/compress
app/assets/javascripts/codemirror-4.2/bin/lint
app/assets/javascripts/codemirror-4.2/bin/release
app/assets/javascripts/codemirror-4.2/bin/source-highlight
app/assets/javascripts/codemirror-4.2/LICENSE

[jrafanie]

cc @Fryguy @kbrock @dclarizio all that for ''
💣

[Fryguy]

What does the config.asset_path change do? We still have assets in public, so will they be messed up?

EDIT: I read the comment...just still don't get it 😄

[kbrock]

I read the comment... I read that the config option is ignored, so we just commented it out.

[jrafanie]

@Fryguy I assumed we were using asset pipeline only so it was confusing we set asset path which is ignored with the pipeline. If we are using both, I'll drop the commit

[dclarizio]

@jrafanie I think timelines had an issue with pipeline, so that's still in public and I still see the XML/SWF charts library in there as well.

[miq-bot]

Checked commit jrafanie@569d0d8 with rubocop 0.21.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

[jrafanie]

Ok @Fryguy @dclarizio @kbrock dropped the asset_path commit since we're half using the pipeline. Opened #502 for using the asset pipeline fully.

[kbrock]

👍 good find / solution