Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UI changes to flag invalid catalog items in the UI #4415

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Sep 17, 2015

@lgalis
Copy link
Contributor Author

lgalis commented Sep 17, 2015

@miq-bot add_label ui, enhancement, wip

@lgalis lgalis force-pushed the ui_changes_for_flagging_invalid_catalog_items branch from 1f3354b to fe072f5 Compare September 17, 2015 20:57
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@lgalis lgalis force-pushed the ui_changes_for_flagging_invalid_catalog_items branch from fe072f5 to c826fe3 Compare October 7, 2015 13:08
@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2015

Checked commits lgalis/manageiq@00b8306~...c826fe3 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
2 files checked, 9 offenses detected

app/controllers/catalog_controller.rb

spec/controllers/catalog_controller_spec.rb

  • 🔴 Error - Line 509, Col 1 - Syntax - unexpected token $end

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@romanblanco
Copy link
Member

@lgalis this PR seems to be untouched for quite long time, do you still plan to work on it?
The BZ ticket is already verified.

@lgalis
Copy link
Contributor Author

lgalis commented Jan 9, 2017

Will open a new PR on the spilt UI Repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants