Angular host editor #3859

h-kataria · 2015-08-13T14:57:10Z

No description provided.

h-kataria · 2015-08-13T17:07:43Z

@AparnaKarve can you review/test this, i still need to add more Jasmine tests to this PR and some further refactoring if possible, but i need someone to review this.

2. Used auth_credentials_angular haml for Default and Remote Tabs

- This commit handles any issues found during angular host editor testing. - Further cleanup of controller code and fixed existing spec tests. Added Jasmine tests for host editor.

Also made a few other adjustments in the haml

h-kataria · 2015-08-19T21:38:06Z

@dclarizio this PR is ready for review/testing.

miq-bot · 2015-08-20T12:12:45Z

Checked commits h-kataria@aad7338 .. h-kataria@62a7442 with rubocop 0.32.1 and haml-lint 0.13.0
10 files checked, 110 offenses detected

app/controllers/host_controller.rb

app/views/host/_form.html.haml

🔴 Warn - Line 1, Col - - Style/VariableName: Use snake_case for variable names.
🔴 Warn - Line 39, Col - - Line is too long. [132/120]
🔴 Warn - Line 43, Col - - Style/HashSyntax: Use hash rockets syntax.
🔴 Warn - Line 44, Col - - Line is too long. [143/120]
🔴 Warn - Line 86, Col - - The = symbol should have one space separating it from code
🔴 Warn - Line 87, Col - - The = symbol should have one space separating it from code
🔴 Warn - Line 98, Col - - Line is too long. [136/120]

app/views/layouts/_auth_credentials_form.html.haml

app/views/layouts/angular-bootstrap/_auth_credentials_angular_bootstrap.html.haml

app/views/layouts/angular/_auth_credentials_angular.html.haml

app/views/layouts/angular/_form_buttons_verify_angular.html.haml

🔴 Warn - Line 12, Col - - Style/SpaceInsideParens: Space inside parentheses detected.
🔴 Warn - Line 17, Col - - Line is too long. [140/120]

app/views/layouts/angular/_multi_auth_credentials.html.haml

🔴 Warn - Line 29, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 48, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 63, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 78, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 94, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 109, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 124, Col - - %div.style1 can be written as .style1 since %div is implicit
🔴 Warn - Line 145, Col - - Style/HashSyntax: Use hash rockets syntax.
🔴 Warn - Line 146, Col - - Line is too long. [137/120]

spec/controllers/host_controller_spec.rb

🔶 - Line 93, Col 9 - Style/AlignParameters - Align the parameters of a method call if they span more than one line.
🔶 - Line 98, Col 7 - Style/ClosingParenthesisIndentation - Align ) with (.
🔶 - Line 112, Col 9 - Style/AlignParameters - Align the parameters of a method call if they span more than one line.
🔶 - Line 121, Col 7 - Style/ClosingParenthesisIndentation - Align ) with (.
🔶 - Line 132, Col 9 - Style/AlignParameters - Align the parameters of a method call if they span more than one line.
🔶 - Line 135, Col 7 - Style/ClosingParenthesisIndentation - Align ) with (.

AparnaKarve · 2015-08-20T22:08:03Z

@dclarizio, @h-kataria and I worked together on this PR and have reviewed and tested each other's commits.
Also tested @epwinchell 's styling update commit.
This is good to go. 👍

Angular host editor

himdel · 2015-10-21T13:58:21Z

app/assets/javascripts/application.js

@@ -10,7 +10,6 @@
 //= require services/miq_db_backup_service
 //= require directives/scheduler/updateDropdownForFilter
 //= require directives/scheduler/updateDropdownForTimer
-//= require directives/miq_calendar


@h-kataria any reason for this change? You've broken the retirement editor ;).

@himdel i don't recall why that was removed, maybe just an oversight or result of bad merge/rebase from master

OK, just checking, Milan will add it back, thanks :).

himdel · 2017-01-03T16:34:09Z

app/helpers/application_helper.rb

+    content_tag(:li,
+                :class     => "#{options[:class]} #{active == id ? 'active' : ''}",
+                :id        => "#{id}_tab",
+                'ng-click' => "changeAuthTab('#{id}');") do


@h-kataria Do you remember why this change was needed please?

Because now it is putting that ng-click in every tab, everywhere ... which will break once those other screens are actually angular and try to call it.

I'll move it to options, and I'm assuming this is only needed in app/views/layouts/_multi_auth_credentials_form.html.haml but .. if you know more.. :)

@himdel It looks like this change was added to keep track of the current tab that user is on in the form, it was added by @AparnaKarve in 5b227b5 maybe she remembers if there was some other purpose behind adding that ng-click

@himdel Yeah, the main purpose was to handle tab-specific logic in the angular controller.
If there are tabs, there will be tab-specific logic, meaning we would always have changeAuthTab in every angular controller that deals with tabs and hence chances of something breaking probably don't exist.

Aah, thanks :) Ok, I'll move it to that template then, so that we explicitly pass {'ng-click' => "changeAuthTab('something')"} in there...

Fixed in ManageIQ/manageiq-ui-classic@2b1da75

h-kataria added enhancement ui labels Aug 13, 2015

h-kataria self-assigned this Aug 13, 2015

h-kataria added the wip label Aug 13, 2015

h-kataria force-pushed the angular_host_editor branch from 70d904a to 7042fe1 Compare August 13, 2015 17:06

h-kataria force-pushed the angular_host_editor branch 4 times, most recently from 751d43a to 09c1fc5 Compare August 17, 2015 22:13

AparnaKarve force-pushed the angular_host_editor branch 4 times, most recently from 046d1a3 to b8c88ad Compare August 18, 2015 19:29

h-kataria force-pushed the angular_host_editor branch from b8c88ad to ffb1466 Compare August 18, 2015 21:11

AparnaKarve force-pushed the angular_host_editor branch from ffb1466 to d399ff1 Compare August 19, 2015 14:16

h-kataria and others added 6 commits August 19, 2015 10:11

Host Angular editor changes.

aad7338

1. Some adjustments that are common for all Angular forms

5409d02

2. Used auth_credentials_angular haml for Default and Remote Tabs

Further changes to host editor & multi tab code.

7c0a216

Fixed multi-tabs and used the angular-bootstrap haml for credentials

3708cdb

Further changes to host angular editor.

8a0ed80

- This commit handles any issues found during angular host editor testing. - Further cleanup of controller code and fixed existing spec tests. Added Jasmine tests for host editor.

Used layouts/angular/x_edit_buttons_angular partial for the buttons

836e5eb

Also made a few other adjustments in the haml

AparnaKarve force-pushed the angular_host_editor branch from d399ff1 to 836e5eb Compare August 19, 2015 17:17

h-kataria removed the wip label Aug 19, 2015

h-kataria changed the title ~~[WIP] - Angular host editor~~ Angular host editor Aug 19, 2015

h-kataria force-pushed the angular_host_editor branch 2 times, most recently from 52f3854 to 62a7442 Compare August 19, 2015 21:34

Addressed rubocop comments

bf35a05

h-kataria force-pushed the angular_host_editor branch from 62a7442 to bf35a05 Compare August 20, 2015 13:23

made form styling updates

4fbbce1

h-kataria mentioned this pull request Aug 20, 2015

UI: Need to change Angular multi authentication credentials tabs to be built dynamically #3973

Closed

dclarizio pushed a commit that referenced this pull request Aug 20, 2015

Merge pull request #3859 from h-kataria/angular_host_editor

63be744

Angular host editor

dclarizio merged commit 63be744 into ManageIQ:master Aug 20, 2015

dclarizio deleted the angular_host_editor branch August 20, 2015 22:45

dclarizio added this to the Sprint 28 Ending August 24, 2015 milestone Aug 20, 2015

h-kataria mentioned this pull request Aug 27, 2015

UI: Rewrite Host editor using AngularJS #1232

Closed

himdel reviewed Oct 21, 2015
View reviewed changes

himdel reviewed Jan 3, 2017

View reviewed changes

himdel mentioned this pull request Mar 6, 2020

Remove unused layouts ManageIQ/manageiq-ui-classic#6741

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular host editor #3859

Angular host editor #3859

h-kataria commented Aug 13, 2015

h-kataria commented Aug 13, 2015

h-kataria commented Aug 19, 2015

miq-bot commented Aug 20, 2015

AparnaKarve commented Aug 20, 2015

himdel Oct 21, 2015

h-kataria Oct 21, 2015

himdel Oct 21, 2015

himdel Jan 3, 2017

h-kataria Jan 3, 2017

AparnaKarve Jan 3, 2017

himdel Jan 4, 2017

himdel Jan 4, 2017

Angular host editor #3859

Angular host editor #3859

Conversation

h-kataria commented Aug 13, 2015

h-kataria commented Aug 13, 2015

h-kataria commented Aug 19, 2015

miq-bot commented Aug 20, 2015

AparnaKarve commented Aug 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment