Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style1 to patternfly conversion in configuration #3711

Merged
merged 2 commits into from
Sep 15, 2015
Merged

Style1 to patternfly conversion in configuration #3711

merged 2 commits into from
Sep 15, 2015

Conversation

PanSpagetka
Copy link
Contributor

Parent issue: #3139

Before:
editprofilebefore

After:
editprofileafter

Before:
editzonebefore

After:
firefox_screenshot_2015-09-14t13-15-10 233z

Before:
serversetingauthenticationbefore

After:
serversetingauthenticationafter

Before:
serversetingcustomlogosbefore

After:
serversetingcustomlogosafter

Before:
serversetingdatabasebefore

After:
serversetingdatabaseafter

Before:
serversetingserverbefore

After:
firefox_screenshot_2015-09-14t14-04-39 913z
firefox_screenshot_2015-09-14t14-07-22 305z

Before:
serversetingworkersbefore
7b

After:
firefox_screenshot_2015-09-14t14-09-59 497z
firefox_screenshot_2015-09-14t14-10-05 929z

Before:
showsettingsanalysisbefore

After:
showsettingsanalysisafter

Before:
diagnosticregiondatabasebefore

After:
firefox_screenshot_2015-09-15t10-38-08 524z

Before:
diagnosticzonerolesbyserversbefore

After:
diagnosticzonerolesbyserversafter

Before:
diagnosticzoneserversbyrolesbefore

After:
diagnosticzoneserversbyrolesafter

Before:
settingsregionimportbefore

After:
settingsregionimportafter

Before:
settingsregiontagsbefore

After:
settingsregiontagsafter

Before:

vmdbtableshowafter

After:
vmdbtableshowbefore
15.
Before:
accesscontroladdnewuserbefore

After:
accesscontroladdnewuserafter

Before:
addnewrolebefore

After:
addnewroleafter

Before:
diagnosticregionreplicationbefore

After:
diagnosticregionreplicationafter

Before:
accescontroleditgroupbefore

After:
accescontroleditgroupafter

Before:
settingsregionrhupdateseditbefore

After:
settingsregionrhupdateseditafter

Before:
diagnosticzonecugapcollectionbefore

After:
firefox_screenshot_2015-09-14t14-17-15 889z

Before:
addanalzsisvmprofilebefore

After:
addanalzsisvmprofileafter

@epwinchell @dclarizio @skateman Please review

@miq-bot
Copy link
Member

miq-bot commented Aug 4, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 3 times, most recently from 85582e2 to 4a4d508 Compare August 4, 2015 13:21
@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 5 times, most recently from c163ea2 to 3dccd02 Compare August 5, 2015 13:09
@PanSpagetka
Copy link
Contributor Author

@miq-bot add_label wip

@miq-bot miq-bot added the wip label Aug 5, 2015
@PanSpagetka PanSpagetka changed the title Style1 to patternfly conversion in configuration [WIP]Style1 to patternfly conversion in configuration Aug 5, 2015
@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 2 times, most recently from f05a06c to 9b36759 Compare August 5, 2015 14:13
@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 10 times, most recently from 241543b to bad984c Compare August 6, 2015 14:52
@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 2 times, most recently from 0f9ae3b to f976fe5 Compare August 10, 2015 11:53
@miq-bot
Copy link
Member

miq-bot commented Aug 21, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@epwinchell
Copy link
Contributor

@PanSpagetka Cool. Only for the 2 column layouts

@PanSpagetka PanSpagetka force-pushed the ops-table-conversion branch 2 times, most recently from 918380e to d506ab0 Compare August 26, 2015 09:19
@miq-bot
Copy link
Member

miq-bot commented Sep 2, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@romanblanco
Copy link
Member

@PanSpagetka please update your PR as is described in #4197

@PanSpagetka
Copy link
Contributor Author

@miq-bot remove_label wip

@PanSpagetka
Copy link
Contributor Author

Updated, @epwinchell @skateman please review

@PanSpagetka PanSpagetka changed the title [WIP]Style1 to patternfly conversion in configuration Style1 to patternfly conversion in configuration Sep 7, 2015
@miq-bot miq-bot removed the wip label Sep 7, 2015
@serenamarie125
Copy link

@PanSpagetka, why are the text fields so wide? Is that the default when using PatternFly styling ?

@PanSpagetka
Copy link
Contributor Author

@serenamarie125 yes, when we use :class => "form-control" text fields are as wide as upper element, in this case .col-md-8

@miq-bot
Copy link
Member

miq-bot commented Sep 9, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@epwinchell
Copy link
Contributor

@PanSpagetka a bunch of the fieldsets are now nested (screenshot - 1, 6 ,etc) please compare to the "before" screenshots.

@epwinchell
Copy link
Contributor

@PanSpagetka screenshot 9 selects are not converted and fieldsets are nested

epwinchell
epwinchell reviewed Sep 10, 2015
View reviewed changes
app/views/ops/_diagnostics_cu_repair_tab.html.haml
.form-group
%label.col-md-2.control-label
= _("Start Date")
.col-md-8{:style => "padding-right: 5px"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PanSpagetka remove inline styling add form-control

@PanSpagetka
Copy link
Contributor Author

@epwinchell Sorry for such a big and ugly PR. I swear, by the old gods and the new, that I will never make it again.
Pictures 2, 6, 7, updated - fieldsets
Picture 9 updated - fieldsets, dropdown, bootstrap input-group
Picture 20 updated - removed inline styling

@miq-bot
Copy link
Member

miq-bot commented Sep 15, 2015

Checked commits PanSpagetka/manageiq@925c4f4~...07b1315 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0
27 files checked, 96 offenses detected

app/presenters/tree_builder_ops.rb

app/views/_ldap_domain_form.html.haml

  • 🔴 Warn - Line 3, Col - - Line is too long. [146/120]
  • 🔴 Warn - Line 10, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 22, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 22, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 22, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 22, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 48, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 103, Col - - Line is too long. [126/120]

app/views/layouts/angular/_edit_log_depot_settings_angular.html.haml

  • 🔴 Warn - Line 6, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 6, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 6, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 6, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 20, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 20, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 20, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 20, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 20, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_ap_form.html.haml

  • 🔴 Warn - Line 4, Col - - Line is too long. [125/120]

app/views/ops/_ap_form_set.html.haml

  • 🔴 Warn - Line 10, Col - - Style/EmptyLiteral: Use array literal [] instead of Array.new.

app/views/ops/_diagnostics_cu_repair_tab.html.haml

  • 🔴 Warn - Line 17, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 17, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 17, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_diagnostics_database_tab.html.haml

  • 🔴 Warn - Line 3, Col - - Line is too long. [286/120]
  • 🔴 Warn - Line 55, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 55, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 69, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 69, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 69, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 69, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 69, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 78, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 79, Col - - Line is too long. [125/120]
  • 🔴 Warn - Line 80, Col - - Line is too long. [153/120]
  • 🔴 Warn - Line 82, Col - - Line is too long. [146/120]
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 86, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 89, Col - - Line is too long. [154/120]
  • 🔴 Warn - Line 90, Col - - Line is too long. [156/120]
  • 🔴 Warn - Line 91, Col - - Line is too long. [154/120]
  • 🔴 Warn - Line 102, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 102, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 102, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 102, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_ldap_auth_users.html.haml

  • 🔴 Warn - Line 10, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_selected_by_servers.html.haml

  • 🔴 Warn - Line 9, Col - - = "..." should be rewritten as ...
  • 🔴 Warn - Line 72, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 72, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 72, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_settings_authentication_tab.html.haml

  • 🔴 Warn - Line 138, Col - - Line is too long. [123/120]

app/views/ops/_settings_co_tags_tab.html.haml

  • 🔴 Warn - Line 11, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_settings_import_tab.html.haml

  • 🔴 Warn - Line 12, Col - - Style/ExtraSpacing: Unnecessary spacing detected.

app/views/ops/_settings_rhn_edit_tab.haml

  • 🔴 Warn - Line 31, Col - - Style/ExtraSpacing: Unnecessary spacing detected.
  • 🔴 Warn - Line 106, Col - - Line is too long. [165/120]

app/views/ops/_settings_server_tab.html.haml

  • 🔴 Warn - Line 91, Col - - Line is too long. [125/120]
  • 🔴 Warn - Line 121, Col - - Line is too long. [133/120]
  • 🔴 Warn - Line 135, Col - - Line is too long. [133/120]
  • 🔴 Warn - Line 244, Col - - Line is too long. [157/120]

app/views/ops/_settings_workers_tab.html.haml

  • 🔴 Warn - Line 15, Col - - Line is too long. [154/120]
  • 🔴 Warn - Line 26, Col - - Line is too long. [148/120]
  • 🔴 Warn - Line 41, Col - - Line is too long. [167/120]
  • 🔴 Warn - Line 51, Col - - Line is too long. [171/120]
  • 🔴 Warn - Line 65, Col - - Line is too long. [125/120]
  • 🔴 Warn - Line 79, Col - - Line is too long. [131/120]
  • 🔴 Warn - Line 96, Col - - Line is too long. [129/120]
  • 🔴 Warn - Line 114, Col - - Line is too long. [140/120]
  • 🔴 Warn - Line 124, Col - - Line is too long. [148/120]
  • 🔴 Warn - Line 138, Col - - Line is too long. [122/120]
  • 🔴 Warn - Line 148, Col - - Line is too long. [128/120]
  • 🔴 Warn - Line 162, Col - - Line is too long. [141/120]
  • 🔴 Warn - Line 172, Col - - Line is too long. [149/120]
  • 🔴 Warn - Line 188, Col - - Line is too long. [143/120]
  • 🔴 Warn - Line 198, Col - - Line is too long. [149/120]
  • 🔴 Warn - Line 212, Col - - Line is too long. [156/120]
  • 🔴 Warn - Line 222, Col - - Line is too long. [162/120]
  • 🔴 Warn - Line 236, Col - - Line is too long. [125/120]
  • 🔴 Warn - Line 249, Col - - Line is too long. [126/120]
  • 🔴 Warn - Line 259, Col - - Line is too long. [132/120]
  • 🔴 Warn - Line 272, Col - - Line is too long. [135/120]
  • 🔴 Warn - Line 281, Col - - Line is too long. [129/120]
  • 🔴 Warn - Line 290, Col - - Line is too long. [133/120]
  • 🔴 Warn - Line 299, Col - - Line is too long. [137/120]
  • 🔴 Warn - Line 308, Col - - Line is too long. [131/120]
  • 🔴 Warn - Line 317, Col - - Line is too long. [129/120]

@epwinchell
Copy link
Contributor

@dclarizio Looks good

dclarizio pushed a commit that referenced this pull request Sep 15, 2015
Merge pull request #3711 from PanSpagetka/ops-table-conversion
034c6e7 
Style1 to patternfly conversion in configuration
@dclarizio dclarizio merged commit 034c6e7 into ManageIQ:master Sep 15, 2015
@dclarizio dclarizio added this to the Sprint 30 Ending Oct 5, 2015 milestone Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
technical debt ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PanSpagetka @miq-bot @epwinchell @romanblanco @serenamarie125 @chessbyte @dclarizio