Added CRUD support for Automate Domains.

[h-kataria]

• Added support to Add/Edit/Delete Automate Domains. Moved some of the methods to private area and changed existing code that was being used to add/edit namespaces to be used for add/edit of domains.
• Added support to change priority of Automate Domains.
• Added support to allow users to local/unlock domains. This feature is protected by RBAC, so only users that have access to these features will be able to see these buttons.
• Added product features for the new buttons.
• Changed role_allows? method in user model to check for allows_any? feature when a hidden feature comes in.
• Added spec tests to verify, lock/unlock and priority order change features.
• Fixed any broken spec tests in application_helper specs, deleted any AE related spec tests that aren't valid any more.
• Fixed an issue where correct tabs were not shown as inactive tabs on edit screen.

Issue #2045

@dclarizio please review/test.

[Fryguy]

@martinpovolny @mkanoor @gmcculloug @tinaafitz Please review.

[martinpovolny]

I would instantiate a variable, such as
verb = @edit[:rec_id].nil? 'create' : 'update'

and then make a hash
{ 'instances' => '_instance', 'props' => '' ...etc}
then calculate the value of the action_url from the 2 parts (hash lookup + verb)\

that would make the eeeextra loooooong method a bit shorter

and then I would put all that stuff into a separate method such as
action_url = calculate_action_url(nodes.first,...) or something like that

[h-kataria]

@martinpovolny @mkanoor ready for re-review, made suggested changes.

[h-kataria]

@martinpovolny made suggested changes

[martinpovolny]

@h-kataria : I wonder if you have Rubocop setup locally? If not I'd suggest that you install it and take the config that we have here so that you can address Rubocop complaints comfortably. Most of the above are actually quite sane. If you need some help with Rubocop, ask me anytime!

[martinpovolny]

could we, please, make the above look like

@edit = {
 :new => {
    :ns_name => ....
    ...
  },
  :key =>
 ...

should be less characters and actually more readable

[miq-bot]

Checked commits h-kataria@f7e08ad .. h-kataria@d003bb3 with rubocop 0.21.0
8 files checked, 17 offenses detected

vmdb/app/controllers/miq_ae_class_controller.rb

• Warn - Line 2553, Col 81 - BlockAlignment - end at 2553, 80 is not aligned with MiqAeDomain.order('priority DESC').collect { |domain| @edit[:new][:domain_order].push("#{domain.editable? ? at 2552, 4
• Style - Line 1906, Col 3 - MethodLength - Method has too many lines. [27/25]
• Style - Line 1939, Col 3 - CyclomaticComplexity - Cyclomatic complexity for create_action_url is too high. [10/6]
• Style - Line 2071, Col 3 - CyclomaticComplexity - Cyclomatic complexity for delete_domain_or_namespaces is too high. [8/6]
• Style - Line 2071, Col 3 - MethodLength - Method has too many lines. [32/25]
• Style - Line 2261, Col 29 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• Style - Line 2263, Col 36 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• Style - Line 2265, Col 29 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• Style - Line 2520, Col 3 - CyclomaticComplexity - Cyclomatic complexity for set_ns_form_vars is too high. [9/6]
• Style - Line 2520, Col 7 - AccessorMethodName - Do not prefix writer method names with set_.
• Style - Line 2537, Col 24 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.
• Style - Line 2539, Col 49 - NestedTernaryOperator - Ternary operators must not be nested. Prefer if/else constructs instead.
• Style - Line 2541, Col 49 - NestedTernaryOperator - Ternary operators must not be nested. Prefer if/else constructs instead.
• Style - Line 2552, Col 48 - Blocks - Avoid using {...} for multi-line blocks.
• Style - Line 2552, Col 94 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.

vmdb/app/models/user.rb

• Style - Line 178, Col 5 - MultilineTernaryOperator - Avoid multi-line ?: (the ternary operator); use if/unless instead.

vmdb/spec/controllers/miq_ae_class_controller_spec.rb

• Style - Line 83, Col 49 - Blocks - Avoid using {...} for multi-line blocks.

[dclarizio]

@h-kataria @martinpovolny We will address the remaining rubocop comments in a follow up commit. I am merging this to get the functionality into the next build.