Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update plugin generator to switch from rails secrets to credentials #23266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Update plugin generator to switch from rails secrets to credentials #23266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/generators/manageiq/plugin/plugin_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ def create_plugin_files
template "bin/before_install"
chmod "bin", 0o755 & ~File.umask, :verbose => false
empty_directory_with_keep_file "bundler.d"
template "config/secrets.defaults.yml"
template "config/settings.yml"
template "lib/%plugin_path%.rb"
template "lib/%plugin_path%/engine.rb"
Expand Down
1 change: 0 additions & 1 deletion lib/generators/manageiq/plugin/templates/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/.yardoc
/Gemfile.lock
/_yardoc/
/config/secrets.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New plugins should not have existing secrets to worry about accidentally committing. Additionally, rails credentials aren't stored in the plugin directory, so we only need to .gitignore in the manageiq application.

/coverage/
/doc/
/pkg/
Expand Down
7 changes: 0 additions & 7 deletions lib/generators/manageiq/plugin/templates/config/secrets.defaults.yml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions lib/generators/manageiq/plugin/templates/lib/%plugin_path%/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ class Engine < ::Rails::Engine

config.autoload_paths << root.join('lib').to_s

initializer :append_secrets do |app|
app.config.paths["config/secrets"] << root.join("config", "secrets.defaults.yml").to_s
app.config.paths["config/secrets"] << root.join("config", "secrets.yml").to_s
end

def self.vmdb_plugin?
true
end
Expand Down