Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English Translations #23233

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

miq-bot
Copy link
Member

@miq-bot miq-bot commented Oct 15, 2024

Update the English Translations in the manageiq.po and manageiq.pot files.

@Fryguy
Copy link
Member

Fryguy commented Oct 15, 2024

@jrafanie Does it make sense to change the automated PRs to update the non-english message catalogs, particularly when a string is deleted? The reason that #23218 is failing is because the non-english catalogs still have the old strings, even though they've been deleted in the .pot and the english .po. I was hoping this PR would have those strings removed from the non-english catalogs, but that's not how it works currently.

@jrafanie
Copy link
Member

@jrafanie Does it make sense to change the automated PRs to update the non-english message catalogs, particularly when a string is deleted? The reason that #23218 is failing is because the non-english catalogs still have the old strings, even though they've been deleted in the .pot and the english .po. I was hoping this PR would have those strings removed from the non-english catalogs, but that's not how it works currently.

Maybe but that's not how the workflow occurs. We don't ever really merge the non-english po files except from translators. If we remove things in the english pot, it should be removed when the translators apply the changes and provide the updated po files.

@miq-bot miq-bot force-pushed the update_english_translations branch from c9ad7a8 to 7ca1e98 Compare November 1, 2024 00:34
@miq-bot miq-bot requested a review from Fryguy as a code owner November 1, 2024 00:34
@miq-bot miq-bot force-pushed the update_english_translations branch from 7ca1e98 to bd948a0 Compare November 13, 2024 14:01
@miq-bot miq-bot force-pushed the update_english_translations branch from bd948a0 to f48b179 Compare November 15, 2024 00:24
@miq-bot
Copy link
Member Author

miq-bot commented Nov 15, 2024

Checked commit miq-bot@f48b179 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@@ -19393,9 +19393,6 @@ msgstr ""
msgid "Edit this Provider"
msgstr ""

msgid "Edit this Region"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msgid ""
"Host to validate against, Username and matching password fields are needed to "
"perform verification of credentials"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -12962,9 +12959,6 @@ msgstr ""
msgid "Copy from provisioning"
msgstr ""

msgid "Copy object details for use in a Button"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -879,9 +879,6 @@ msgstr ""
msgid "%{name} (All %{title})"
msgstr ""

msgid "%{name} (All Generic Objects)"
msgstr ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


msgid "EVM: Recently Discovered VMs"
msgstr ""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in #23264

"ct copied from the Simulation screen"
msgstr ""

msgid "Paste object details for use in a Button."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@jrafanie jrafanie merged commit 10619c0 into ManageIQ:master Nov 15, 2024
8 checks passed
@jrafanie
Copy link
Member

The parent commits that this depends on were already brought back in radjabov.

@Fryguy
Copy link
Member

Fryguy commented Nov 19, 2024

Backported to radjabov in commit 7ddc07b.

commit 7ddc07b2ee8866bd2f02d3b248b00a9f09228876
Author: Joe Rafaniello <[email protected]>
Date:   Fri Nov 15 16:49:49 2024 -0500

    Merge pull request #23233 from miq-bot/update_english_translations
    
    Update English Translations
    
    (cherry picked from commit 10619c007e16cd4bc28e837fb50c9c007c7ca628)

Fryguy pushed a commit that referenced this pull request Nov 19, 2024
Update English Translations

(cherry picked from commit 10619c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants