-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rails71 #23225
base: master
Are you sure you want to change the base?
[WIP] Rails71 #23225
Conversation
8888823
to
35c7f80
Compare
95c915c
to
728da06
Compare
0eb4c64
to
ea2d65d
Compare
@miq-bot cross-repo-tests /all, ManageIQ/activerecord-virtual_attributes#168 |
From Pull Request: ManageIQ/manageiq#23225
This pull request is not mergeable. Please rebase and repush. |
In ManageIQ#23171, we found that we weren't using the legacy connection handlers and disabled using them in rails 7.0. Now, in 7.1, this option has been removed, so it's safe to remove this option entirely.
Rails 7.1 removed the table_name alias to name so just use name: See: https://www.github.com/rails/rails/pull/46864 Rails 7.1 removed the writer for the table_alias so set the instance variable. We will need to see if there is a way to do this that's less brittle. See: https://www.github.com/rails/rails/pull/48927
It's unclear if it fixes all the issues as you can call alias_attribute anywhere up the ancestry tree and it's possible lazy loading is preventing them from being loaded. See: https://www.github.com/rails/rails/issues/52820 https://www.github.com/rails/rails/pull/52842 (7.1 backport: https://www.github.com/rails/rails/pull/52844) Looks like it's still an issue in some situations: https://www.github.com/rails/rails/issues/50154 https://www.github.com/rails/rails/issues/51717
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually.
This reverts commit e7acb3235e840aa89d479bf3993a08c53fc13e57. VERIFY we can drop this revert and the original commit pending due to https://www.github.com/ManageIQ/activerecord-virtual_attributes/pull/168
This reverts commit e4fa809. TODO Let's see if this is needed with rails 7.1
Checked commits jrafanie/manageiq@a15d358~...a2c11c2 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint Gemfile
app/models/automation_request.rb
app/models/automation_task.rb
app/models/manageiq/providers/embedded_automation_manager/authentication.rb
app/models/miq_provision.rb
app/models/miq_provision_request.rb
app/models/persistent_volume.rb
app/models/physical_switch.rb
app/models/resource_group.rb
app/models/service.rb
app/models/service_template_provision_request.rb
app/models/vm_migrate_task.rb
app/models/vm_reconfigure_task.rb
app/models/vm_retire_task.rb
|
No description provided.