Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rails71 #23225

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[WIP] Rails71 #23225

wants to merge 13 commits into from

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 7, 2024

No description provided.

@jrafanie jrafanie requested a review from Fryguy as a code owner October 7, 2024 22:45
@jrafanie jrafanie changed the title [WIPRails71 [WIP] Rails71 Oct 7, 2024
@jrafanie jrafanie force-pushed the rails71 branch 2 times, most recently from 8888823 to 35c7f80 Compare October 7, 2024 22:53
@jrafanie jrafanie mentioned this pull request Oct 10, 2024
42 tasks
@jrafanie jrafanie force-pushed the rails71 branch 2 times, most recently from 95c915c to 728da06 Compare October 29, 2024 19:37
@jrafanie jrafanie force-pushed the rails71 branch 2 times, most recently from 0eb4c64 to ea2d65d Compare January 7, 2025 23:01
@jrafanie
Copy link
Member Author

jrafanie commented Jan 8, 2025

@miq-bot cross-repo-tests /all, ManageIQ/activerecord-virtual_attributes#168

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 8, 2025
@miq-bot
Copy link
Member

miq-bot commented Jan 16, 2025

This pull request is not mergeable. Please rebase and repush.

In ManageIQ#23171, we found that we weren't using the legacy connection handlers
and disabled using them in rails 7.0.  Now, in 7.1, this option has been
removed, so it's safe to remove this option entirely.
Rails 7.1 removed the table_name alias to name so just use name:
See: https://www.github.com/rails/rails/pull/46864

Rails 7.1 removed the writer for the table_alias so set the instance
variable. We will need to see if there is a way to do this that's less brittle.
See: https://www.github.com/rails/rails/pull/48927
It's unclear if it fixes all the issues as you can call alias_attribute
anywhere up the ancestry tree and it's possible lazy loading is preventing
them from being loaded.

See:

https://www.github.com/rails/rails/issues/52820
https://www.github.com/rails/rails/pull/52842
(7.1 backport: https://www.github.com/rails/rails/pull/52844)

Looks like it's still an issue in some situations:
https://www.github.com/rails/rails/issues/50154
https://www.github.com/rails/rails/issues/51717
Fixes deprecation of this variety:

Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually.
This reverts commit e7acb3235e840aa89d479bf3993a08c53fc13e57.

VERIFY we can drop this revert and the original commit pending due to
https://www.github.com/ManageIQ/activerecord-virtual_attributes/pull/168
This reverts commit e4fa809.

TODO Let's see if this is needed with rails 7.1
@miq-bot
Copy link
Member

miq-bot commented Jan 16, 2025

Checked commits jrafanie/manageiq@a15d358~...a2c11c2 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
22 files checked, 33 offenses detected

Gemfile

  • ❗ - Line 25, Col 3 - Style/CommentAnnotation - Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.

app/models/automation_request.rb

  • ❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/automation_task.rb

  • ❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/manageiq/providers/embedded_automation_manager/authentication.rb

  • ❗ - Line 7, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/miq_provision.rb

app/models/miq_provision_request.rb

  • ❗ - Line 5, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 6, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 7, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/persistent_volume.rb

  • ❗ - Line 8, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 9, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/physical_switch.rb

app/models/resource_group.rb

app/models/service.rb

app/models/service_template_provision_request.rb

app/models/vm_migrate_task.rb

  • ❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/vm_reconfigure_task.rb

  • ❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

app/models/vm_retire_task.rb

  • ❗ - Line 2, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.
  • ❗ - Line 3, Col 3 - Style/Alias - Use alias instead of alias_method in a class body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants