Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error display when yarn audits fail #23137

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Aug 7, 2024

@jrafanie Please review:

Before:

** Running yarn npm audit for manageiq-providers-cisco_intersight
**   path:    /Users/jfrey/.gem/ruby/3.1.5/bundler/gems/manageiq-providers-cisco_intersight-9bd5dcd32130
**   command: yarn npm audit --recursive --no-deprecations --environment production --json

** Running yarn npm audit for manageiq-providers-ibm_cloud
**   path:    /Users/jfrey/.gem/ruby/3.1.5/bundler/gems/manageiq-providers-ibm_cloud-c78f10b9d0e7
**   command: yarn npm audit --recursive --no-deprecations --environment production --json

...

After:

** Running yarn npm audit for manageiq-providers-cisco_intersight
**   path:    /Users/jfrey/.gem/ruby/3.1.5/bundler/gems/manageiq-providers-cisco_intersight-9bd5dcd32130
**   command: yarn npm audit --recursive --no-deprecations --environment production --json
Usage Error: This tool requires a Node version compatible with >=18.12.0 (got 18.4.0). Upgrade Node, or set `YARN_IGNORE_NODE=1` in your environment.

━━━ Yarn Package Manager - 4.2.2 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  $ yarn <command>

You can also print more details about any of these commands by calling them with
the `-h,--help` flag right after the command name.

** Running yarn npm audit for manageiq-providers-ibm_cloud
**   path:    /Users/jfrey/.gem/ruby/3.1.5/bundler/gems/manageiq-providers-ibm_cloud-c78f10b9d0e7
**   command: yarn npm audit --recursive --no-deprecations --environment production --json
Usage Error: This tool requires a Node version compatible with >=18.12.0 (got 18.4.0). Upgrade Node, or set `YARN_IGNORE_NODE=1` in your environment.

━━━ Yarn Package Manager - 4.2.2 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  $ yarn <command>

You can also print more details about any of these commands by calling them with
the `-h,--help` flag right after the command name.
...

@Fryguy Fryguy changed the title Improve error display when yarn audits fail [WIP] Improve error display when yarn audits fail Aug 7, 2024
@miq-bot miq-bot added the wip label Aug 7, 2024
@Fryguy Fryguy force-pushed the yarn_audit_better_errors branch from b61c4fe to 749c149 Compare August 7, 2024 20:21
@Fryguy Fryguy changed the title [WIP] Improve error display when yarn audits fail Improve error display when yarn audits fail Aug 7, 2024
@Fryguy Fryguy force-pushed the yarn_audit_better_errors branch from 749c149 to 6c77d03 Compare August 7, 2024 20:23
@Fryguy Fryguy force-pushed the yarn_audit_better_errors branch from 6c77d03 to f5f38ba Compare August 7, 2024 20:24
@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2024

Some comments on commit Fryguy@f5f38ba

lib/tasks/test_security_helper.rb

  • ⚠️ - 96 - Detected puts. Remove all debugging statements.

@miq-bot miq-bot removed the wip label Aug 7, 2024
@miq-bot
Copy link
Member

miq-bot commented Aug 7, 2024

Checked commit Fryguy@f5f38ba with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

lib/tasks/test_security_helper.rb

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@jrafanie jrafanie merged commit 46c992a into ManageIQ:master Aug 7, 2024
8 checks passed
@Fryguy Fryguy deleted the yarn_audit_better_errors branch August 7, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants