Add more ansible runner specs

[Fryguy]

@agrare Please review.

I'm not sure about the wait method, so would like your thoughts there on how better to represent that or perhaps a better method signature.

The first commit is partially copied from #23063 cc @jaisejose1123

[miq-bot]

Checked commits Fryguy/manageiq@39b67ef~...b6d0c4e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 2 offenses detected

lib/ansible/runner/response_async.rb

• ⚠️ - Line 64, Col 29 - Lint/UnusedBlockArgument - Unused block argument - t. You can omit the argument if you don't care about it.

spec/lib/ansible/runner/data/hello_world_vault_encrypted.yml

• ⚠️ - Line 38, Col 5 - indentation - wrong indentation: expected 2 but found 4

[agrare]

Probably scope creep, but I wonder if we could use inotify like we do for Ansible::Runner#wait_for to tell when the playbook starts running by waiting for the pid file. That would eliminate the sleep/poll loop

[Fryguy]

Oh yes, Inotify is a much better option - let me try that

[agrare]

I could see wanting to wait X seconds for this to complete but not want to stop it, could we pull this out and return nil if it timed out or something? That way it is up to the caller if they want to kill the run on timeout or not.

[Fryguy]

I think I want to leave this as is, because I the interface for wait is to return a response object (i.e. turn a response_async object into a response object.

[agrare]

@Fryguy actually if we just want to wait for the process to finish I think it is even easier than using inotify. All ansible-runner is-alive does is a kill signal check to see if the process exists. We could use waitpid to wait for the process to finish, and since we wait for the pid file to be created before returning we don't have to worry about a race if we do File.read(pid) here

[Fryguy]

Oh neat - I didn't realize is-alive was so simple.

[agrare]

    if vargs.get('command') == 'is-alive':
        try:
            os.kill(pid, signal.SIG_DFL)
            return 0
        except OSError:
            return 1

[agrare]

I'll help with the non-polling version in a follow-up