Remove return value sync_workers/sync_starting_workers

[agrare]

These return values don't appear to be used anywhere and make the code slightly more complicated.

Related to: #22941

[Fryguy]

These return values don't appear to be used anywhere and make the code slightly more complicated.

I thought these were used for logging purposes somewhere (maybe not the starting_workers, but the sync_workers results. I recall logging with something showing the current and desired and then which ones it's starting and which ones it's taking down to get to the desired state.

EDIT: I might be thinking of this:

manageiq/app/models/mixins/per_ems_worker_mixin.rb

Lines 24 to 28 in e1eb9f4

	_log.info("Workers are being synchronized: Current: #{current.inspect}, Desired: #{desired.inspect}")
	dups = current.uniq.find_all { |u| current.find_all { |c| c == u }.length > 1 }
	_log.info("Duplicate workers found: Current: #{current.inspect}, Desired: #{desired.inspect}, Dups: #{dups.inspect}") unless dups.empty?
	current -= dups

[Fryguy]

Naming it result is confusing, since we aren't actually returning it anymore. Think this is clearer to read:

Suggested change

	result = klass.sync_workers
	result[:adds].each { |pid| worker_add(pid) unless pid.nil? }
	workers = klass.sync_workers
	workers[:adds].each { |pid| worker_add(pid) unless pid.nil? }

[agrare]

There's an instance-var and attr_reader named workers so I think a local var named the same is also confusing

[Fryguy]

Oh ok, but I still think result is confusing... w or synced_workers could also work... Naming is hard 😅

[agrare]

Okay will go with synced_workers then

[agrare]

@Fryguy I think you're talking about https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/per_ems_worker_mixin.rb#L24 which is in sync_workers

[Fryguy]

Haha yeah I just edited my last comment 😅

I thought that was higher up for some reason.

[miq-bot]

Checked commits agrare/manageiq@49ffc18~...a5c4698 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
6 files checked, 0 offenses detected
Everything looks fine. 🍪