-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Rubocop all the things #22919
Open
Fryguy
wants to merge
205
commits into
ManageIQ:master
Choose a base branch
from
Fryguy:rubocop_all_the_things
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Rubocop all the things #22919
Changes from 1 commit
Commits
Show all changes
205 commits
Select commit
Hold shift + click to select a range
3ab431e
rubocop -a --only Bundler/OrderedGems
Fryguy a2b0ede
rubocop -a --only Layout/ArgumentAlignment
Fryguy e93c342
rubocop -a --only Layout/ArrayAlignment
Fryguy c17d08e
rubocop -a --only Layout/BeginEndAlignment
Fryguy fbeae64
rubocop -a --only Layout/BlockAlignment
Fryguy 60c7c36
rubocop -a --only Layout/BlockEndNewline
Fryguy c5085c6
rubocop -a --only Layout/ClosingHeredocIndentation
Fryguy 5c11e0e
rubocop -a --only Layout/ClosingParenthesisIndentation
Fryguy b30e83e
rubocop -a --only Layout/CommentIndentation
Fryguy cdea9bb
rubocop -a --only Layout/EmptyComment
Fryguy 66fc796
rubocop -a --only Layout/EmptyLineAfterGuardClause
Fryguy 56f86c6
rubocop -a --only Layout/EmptyLineAfterMagicComment
Fryguy 9673ced
rubocop -a --only Layout/EmptyLineBetweenDefs
Fryguy deda507
rubocop -a --only Layout/EmptyLines
Fryguy 0c7dec9
rubocop -a --only Layout/EmptyLinesAroundAttributeAccessor
Fryguy db24a23
rubocop -a --only Layout/EmptyLinesAroundBeginBody
Fryguy ef64dc8
rubocop -a --only Layout/EmptyLinesAroundBlockBody
Fryguy e6aee5c
rubocop -a --only Layout/EmptyLinesAroundClassBody
Fryguy 0359d19
rubocop -a --only Layout/EmptyLinesAroundExceptionHandlingKeywords
Fryguy 7758303
rubocop -a --only Layout/EmptyLinesAroundMethodBody
Fryguy 35f894b
rubocop -a --only Layout/EmptyLinesAroundModuleBody
Fryguy 0125221
rubocop -a --only Layout/ExtraSpacing
Fryguy a01a06d
rubocop -a --only Layout/FirstArgumentIndentation
Fryguy 15b59fe
rubocop -a --only Layout/FirstArrayElementIndentation
Fryguy 473778e
rubocop -a --only Layout/FirstHashElementIndentation
Fryguy 4d42d57
rubocop -a --only Layout/HashAlignment
Fryguy a68ec06
rubocop -a --only Layout/HeredocIndentation
Fryguy e43c15d
rubocop -a --only Layout/IndentationConsistency
Fryguy 6008a35
rubocop -a --only Layout/IndentationStyle
Fryguy 8f46ac6
rubocop -a --only Layout/IndentationWidth
Fryguy 9c04d6c
rubocop -a --only Layout/LeadingCommentSpace
Fryguy 48e9936
rubocop -a --only Layout/LineContinuationLeadingSpace
Fryguy d132a70
rubocop -a --only Layout/LineContinuationSpacing
Fryguy 0d3785e
rubocop -a --only Layout/LineEndStringConcatenationIndentation
Fryguy c15bd2f
rubocop -a --only Layout/MultilineArrayBraceLayout
Fryguy 40e74f6
rubocop -a --only Layout/MultilineBlockLayout
Fryguy 6d6f9a9
rubocop -a --only Layout/MultilineHashBraceLayout
Fryguy 11c5a78
rubocop -a --only Layout/MultilineMethodCallBraceLayout
Fryguy d01a76d
rubocop -a --only Layout/MultilineMethodCallIndentation
Fryguy 96d5e55
rubocop -a --only Layout/MultilineOperationIndentation
Fryguy be5a973
rubocop -a --only Layout/SpaceAfterComma
Fryguy 5d7e38b
rubocop -a --only Layout/SpaceAroundMethodCallOperator
Fryguy c1b6513
rubocop -a --only Layout/SpaceAroundOperators
Fryguy 551ec01
rubocop -a --only Layout/SpaceBeforeBlockBraces
Fryguy ec330e0
rubocop -a --only Layout/SpaceBeforeBrackets
Fryguy 2bf370b
rubocop -a --only Layout/SpaceBeforeComma
Fryguy 1c154b4
rubocop -a --only Layout/SpaceInsideArrayLiteralBrackets
Fryguy 5e820dd
rubocop -a --only Layout/SpaceInsideArrayPercentLiteral
Fryguy 6205af5
rubocop -a --only Layout/SpaceInsideBlockBraces
Fryguy 42880c3
rubocop -a --only Layout/SpaceInsideHashLiteralBraces
Fryguy a5117d0
rubocop -a --only Layout/SpaceInsidePercentLiteralDelimiters
Fryguy 4ea944d
rubocop -a --only Layout/SpaceInsideStringInterpolation
Fryguy d9dd670
rubocop -a --only Layout/TrailingEmptyLines
Fryguy 35d5d82
rubocop -a --only Layout/TrailingWhitespace
Fryguy 22cca16
rubocop -a --only Lint/AmbiguousBlockAssociation
Fryguy 00679c5
rubocop -a --only Lint/AmbiguousOperator
Fryguy 75a6ec5
rubocop -a --only Lint/AmbiguousOperatorPrecedence
Fryguy e880c29
rubocop -a --only Lint/ErbNewArguments
Fryguy a233789
rubocop -a --only Lint/LambdaWithoutLiteralBlock
Fryguy 3391d7b
rubocop -a --only Lint/ParenthesesAsGroupedExpression
Fryguy f91cce3
rubocop -a --only Lint/RedundantSplatExpansion
Fryguy 74fd130
rubocop -a --only Lint/RedundantStringCoercion
Fryguy dc68e37
rubocop -a --only Lint/SendWithMixinArgument
Fryguy 29ffeeb
rubocop -a --only Lint/SymbolConversion
Fryguy 3377702
rubocop -a --only Lint/ToJSON
Fryguy 75ebb12
rubocop -a --only Lint/UnusedBlockArgument
Fryguy 8c6b978
rubocop -a --only Lint/UnusedMethodArgument
Fryguy 29fd459
rubocop -a --only Lint/UriRegexp
Fryguy e15050f
rubocop -a --only Lint/UselessAccessModifier
Fryguy 85a62ff
rubocop -a --only Lint/Void
Fryguy 1d086e1
rubocop -a --only Naming/BinaryOperatorParameterName
Fryguy d347e4a
rubocop -a --only Performance/BindCall
Fryguy b5d6ef9
rubocop -a --only Performance/BlockGivenWithExplicitBlock
Fryguy a64577f
rubocop -a --only Performance/Caller
Fryguy 7c1d63e
rubocop -a --only Performance/CompareWithBlock
Fryguy 863917e
rubocop -a --only Performance/ConstantRegexp
Fryguy 4876626
rubocop -a --only Performance/RedundantBlockCall
Fryguy fa59f02
rubocop -a --only Performance/RedundantMatch
Fryguy ac4798a
rubocop -a --only Performance/RegexpMatch
Fryguy dd36bca
rubocop -a --only Performance/StringIdentifierArgument
Fryguy 9aa955a
rubocop -a --only Performance/StringReplacement
Fryguy 53aa34a
rubocop -a --only Rails/ActiveRecordCallbacksOrder
Fryguy ea3424f
rubocop -a --only Rails/Delegate
Fryguy e828324
rubocop -a --only Rails/DuplicateAssociation
Fryguy 67728f6
rubocop -a --only Rails/DurationArithmetic
Fryguy ae737cb
rubocop -a --only Rails/FilePath
Fryguy af8745c
rubocop -a --only Rails/FindBy
Fryguy 5094c33
rubocop -a --only Rails/IndexBy
Fryguy 225816b
rubocop -a --only Rails/IndexWith
Fryguy 26da9f3
rubocop -a --only Rails/PluralizationGrammar
Fryguy 893cdc6
rubocop -a --only Rails/Presence
Fryguy 679b16a
rubocop -a --only Rails/Present
Fryguy c009644
rubocop -a --only Rails/RedundantForeignKey
Fryguy 342cca2
rubocop -a --only Rails/RootPublicPath
Fryguy 6a324e5
rubocop -a --only Rails/SafeNavigation
Fryguy 35dd991
rubocop -a --only Rails/StripHeredoc
Fryguy c8ed579
rubocop -a --only Rails/TopLevelHashWithIndifferentAccess
Fryguy efe9291
rubocop -a --only Rails/Validation
Fryguy 0a05379
rubocop -a --only Rails/WhereNot
Fryguy 759aebe
rubocop -a --only Style/AccessorGrouping
Fryguy d662a8d
rubocop -a --only Style/Alias
Fryguy c5eca7e
rubocop -a --only Style/ArgumentsForwarding
Fryguy ee3bea6
rubocop -a --only Style/BarePercentLiterals
Fryguy 4bfceb2
rubocop -a --only Style/BlockComments
Fryguy b068888
rubocop -a --only Style/BlockDelimiters
Fryguy 8aef328
rubocop -a --only Style/CaseEquality
Fryguy 79c240f
rubocop -a --only Style/ClassCheck
Fryguy c4278ba
rubocop -a --only Style/ClassEqualityComparison
Fryguy 9e75cd2
rubocop -a --only Style/ColonMethodCall
Fryguy 3c810b0
rubocop -a --only Style/CommentAnnotation
Fryguy c11d1ea
rubocop -a --only Style/ConditionalAssignment
Fryguy 3e328f7
rubocop -a --only Style/EachForSimpleLoop
Fryguy 597cfc3
rubocop -a --only Style/EachWithObject
Fryguy 2c5fc7a
rubocop -a --only Style/EmptyCaseCondition
Fryguy 6d7da75
rubocop -a --only Style/EmptyLiteral
Fryguy b4f7f30
rubocop -a --only Style/EvalWithLocation
Fryguy 45e3430
rubocop -a --only Style/ExpandPathArguments
Fryguy ae7f451
rubocop -a --only Style/ExplicitBlockArgument
Fryguy c334dfc
rubocop -a --only Style/FetchEnvVar
Fryguy 434ba42
rubocop -a --only Style/FileWrite
Fryguy 5a6ec33
rubocop -a --only Style/FormatString
Fryguy 28fc6df
rubocop -a --only Style/HashAsLastArrayItem
Fryguy a1abb42
rubocop -a --only Style/HashSyntax
Fryguy b9b30e7
rubocop -a --only Style/IfInsideElse
Fryguy d6df9eb
rubocop -a --only Style/Lambda
Fryguy c09dc36
rubocop -a --only Style/MethodCallWithArgsParentheses
Fryguy 324c8b7
rubocop -a --only Style/MultilineIfModifier
Fryguy d513b35
rubocop -a --only Style/MultilineMemoization
Fryguy 8e02fdc
rubocop -a --only Style/MultilineTernaryOperator
Fryguy 8cc3a47
rubocop -a --only Style/MultilineWhenThen
Fryguy 4949aa4
rubocop -a --only Style/MultipleComparison
Fryguy 6fd83d0
rubocop -a --only Style/NestedParenthesizedCalls
Fryguy 1e8f1e1
rubocop -a --only Style/NestedTernaryOperator
Fryguy 3c1ca73
rubocop -a --only Style/Next
Fryguy 973925d
rubocop -a --only Style/NumericLiteralPrefix
Fryguy a527752
rubocop -a --only Style/OperatorMethodCall
Fryguy 2f6e83a
rubocop -a --only Style/OrAssignment
Fryguy fe4a742
rubocop -a --only Style/ParenthesesAroundCondition
Fryguy 916593f
rubocop -a --only Style/PercentLiteralDelimiters
Fryguy 38d8786
rubocop -a --only Style/RaiseArgs
Fryguy 0f170fb
rubocop -a --only Style/RandomWithOffset
Fryguy 01e3107
rubocop -a --only Style/RedundantArrayConstructor
Fryguy b16b9ee
rubocop -a --only Style/RedundantAssignment
Fryguy 55758cf
rubocop -a --only Style/RedundantBegin
Fryguy f7c9cb8
rubocop -a --only Style/RedundantCondition
Fryguy fe9f154
rubocop -a --only Style/RedundantConstantBase
Fryguy ccdcec2
rubocop -a --only Style/RedundantCurrentDirectoryInPath
Fryguy 700ce74
rubocop -a --only Style/RedundantFileExtensionInRequire
Fryguy 02fff1a
rubocop -a --only Style/RedundantFilterChain
Fryguy bb2deb4
rubocop -a --only Style/RedundantFreeze
Fryguy 95f2155
rubocop -a --only Style/RedundantLineContinuation
Fryguy e535510
rubocop -a --only Style/RedundantParentheses
Fryguy 0623866
rubocop -a --only Style/RedundantRegexpArgument
Fryguy bf11339
rubocop -a --only Style/RedundantRegexpEscape
Fryguy c08a056
rubocop -a --only Style/RedundantReturn
Fryguy 1a9a4b5
rubocop -a --only Style/RedundantSelf
Fryguy 13d9a58
rubocop -a --only Style/RedundantSelfAssignmentBranch
Fryguy e0813a1
rubocop -a --only Style/RedundantStringEscape
Fryguy 82ac784
rubocop -a --only Style/RescueStandardError
Fryguy 41e453a
rubocop -a --only Style/SingleLineMethods
Fryguy c81a486
rubocop -a --only Style/SoleNestedConditional
Fryguy e9ce040
rubocop -a --only Style/StderrPuts
Fryguy ba3704a
rubocop -a --only Style/TernaryParentheses
Fryguy deb6ca4
rubocop -a --only Style/TrailingCommaInArguments
Fryguy eb09596
rubocop -a --only Style/TrivialAccessors
Fryguy ba869ee
rubocop -a --only Style/UnlessElse
Fryguy 625dfb4
rubocop -a --only Style/UnpackFirst
Fryguy 1c50c5b
rubocop -a --only Layout/ArgumentAlignment
Fryguy 548bde0
rubocop -a --only Layout/ArrayAlignment
Fryguy 2de05c8
rubocop -a --only Layout/AssignmentIndentation
Fryguy 891d2c6
rubocop -a --only Layout/BlockAlignment
Fryguy d36675e
rubocop -a --only Layout/CaseIndentation
Fryguy 8a53f18
rubocop -a --only Layout/ClosingParenthesisIndentation
Fryguy b237fe0
rubocop -a --only Layout/CommentIndentation
Fryguy 0cd8257
rubocop -a --only Layout/ElseAlignment
Fryguy 0c0a6ae
rubocop -a --only Layout/EmptyLineAfterGuardClause
Fryguy 4a2c467
rubocop -a --only Layout/EmptyLineBetweenDefs
Fryguy 16ced30
rubocop -a --only Layout/EmptyLines
Fryguy eed1448
rubocop -a --only Layout/EmptyLinesAroundClassBody
Fryguy efa3224
rubocop -a --only Layout/EndAlignment
Fryguy dd59d35
rubocop -a --only Layout/ExtraSpacing
Fryguy 70db5e7
rubocop -a --only Layout/FirstArgumentIndentation
Fryguy e98de78
rubocop -a --only Layout/FirstArrayElementIndentation
Fryguy 85a0260
rubocop -a --only Layout/FirstHashElementIndentation
Fryguy e90092b
rubocop -a --only Layout/HashAlignment
Fryguy e6f8ed7
rubocop -a --only Layout/HeredocIndentation
Fryguy 7afb463
rubocop -a --only Layout/IndentationConsistency
Fryguy 6f37ffa
rubocop -a --only Layout/IndentationWidth
Fryguy 3b31943
rubocop -a --only Layout/MultilineMethodCallIndentation
Fryguy 2323122
rubocop -a --only Layout/MultilineOperationIndentation
Fryguy 50badb5
rubocop -a --only Layout/SpaceAroundOperators
Fryguy 1e18928
rubocop -a --only Layout/SpaceInsideHashLiteralBraces
Fryguy 155a575
rubocop -a --only Layout/TrailingWhitespace
Fryguy 1327c80
rubocop -a --only Lint/AmbiguousOperator
Fryguy c9e70bd
rubocop -a --only Lint/ElseLayout
Fryguy 16b498e
rubocop -a --only Lint/UnusedMethodArgument
Fryguy ae6f512
rubocop -a --only Performance/BlockGivenWithExplicitBlock
Fryguy 065aa2c
rubocop -a --only Rails/IndexBy
Fryguy 8da62b9
rubocop -a --only Rails/IndexWith
Fryguy d430c26
rubocop -a --only Style/DefWithParentheses
Fryguy 9c15725
rubocop -a --only Style/EmptyElse
Fryguy 4bd50b4
rubocop -a --only Style/FetchEnvVar
Fryguy 4aa31b1
rubocop -a --only Style/ParenthesesAroundCondition
Fryguy 97835c7
rubocop -a --only Style/RedundantAssignment
Fryguy a0fe6fb
rubocop -a --only Style/Semicolon
Fryguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ def cloud_subnets_names | |
allowed_address_pairs fixed_ips).each do |action| | ||
define_method("#{action}=") do |value| | ||
extra_attributes_save(action, value) | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GitHub is presenting this funny, but it's a hidden tab character being fixed to spaces. |
||
|
||
define_method(action) do | ||
extra_attributes_load(action) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub is presenting this funny, but it's a hidden tab character being fixed to spaces.