Fix Build: handle awesome spawn update

[kbrock]

handle change in attributes passed to CommandResult#initialize

  10) Ansible::Runner.run with special characters calls launch with expected arguments
      Failure/Error: let(:result)     { AwesomeSpawn::CommandResult.new("ansible-runner", "output", "", "0") }

      ArgumentError:
        wrong number of arguments (given 4, expected 5)
      # /Users/kbrock/.gem/ruby/3.0.6/gems/awesome_spawn-1.6.0/lib/awesome_spawn/command_result.rb:5:in `initialize'
      # ./spec/lib/ansible/runner_spec.rb:6:in `new'
      # ./spec/lib/ansible/runner_spec.rb:6:in `block (2 levels) in <main>'

[Fryguy]

We probably want to move to stub_good/bad_run here - cc @agrare

[Fryguy]

@kbrock Can you also change the gem reference to enforce 1.6.0 as a minimum version? This will fail in the reverse direction is the old gem is still used.

[miq-bot]

Checked commit kbrock@2a509aa with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[kbrock]

Darn. We do not depend upon awesome spawn. Would prefer not to add it.

Agree with the need though. researching

[agrare]

Darn. We do not depend upon awesome spawn. Would prefer not to add it.

If we use it in core code I think we have to have it in our Gemfile

[Fryguy]

It's probably in manageiq-gems-pending.

[Fryguy]

@kbrock https://github.com/ManageIQ/manageiq-gems-pending/blob/master/manageiq-gems-pending.gemspec#L24

[kbrock]

Did try this but it got in my way:

#require "awesome_spawn/spec_helper"
#  include AwesomeSpawn::SpecHelper

    # anything = Pathname.new(...)
    it "runs ansible-runner with the role" do
      expect(Ansible::Runner).to receive(:async?).and_return(false)
      stub_good_run!("ansible-runner", :env => a_hash_including(env_vars),
        :params => ["start", anything(), :json, {:ident => "result", :role => role_name, :roles_path => role_path, :role_skip_facts => nil}]
      )
      described_class.run_role_async(env_vars, extra_vars, role_name, :roles_path => role_path)
    end

[Fryguy]

Backported to quinteros in commit 04ae74b.

commit 04ae74b73b585392d7ba9fb6474638dd8b470380
Author: Jason Frey <[email protected]>
Date:   Thu Nov 2 12:29:28 2023 -0400

    Merge pull request #22772 from kbrock/awesome_spawn_command
    
    Fix Build: handle awesome spawn update
    
    (cherry picked from commit 8fb050f96962da3870011386b5a4178c7851ca89)