Fix the ems_custom_attributes inventory collection #21623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had a manager_ref of just `:name` but these belong to a polymorphic resource and just the name is not unique. Adding the `:resource` to the manager_ref array makes this unique.
agrare
commented
Dec 16, 2021
| :manager_ref => %i(name), | ||
| :parent_inventory_collections => %i(vms) | ||
| :manager_ref => %i(resource name), | ||
| :parent_inventory_collections => %i(vms miq_templates) |
There was a problem hiding this comment.
This collection (vm_and_template_ems_custom_fields) is used by ovirt and exhibits the same bug, I am going to follow-up with a refactoring to get them both onto the same inventory_collection but want to keep this clean of refactorings for backport
|
@miq-bot cross-repo-tests ManageIQ/manageiq-providers-vmware#771, manageiq-providers-ovirt |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Dec 16, 2021
From Pull Request: ManageIQ/manageiq#21623
|
Checked commit agrare@128cef6 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint app/models/manageiq/providers/inventory/persister/builder/infra_manager.rb
|
1 task
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Dec 16, 2021
From Pull Request: ManageIQ/manageiq#21623
|
@Fryguy PTAL cross repo is green |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jan 10, 2022
…tory_collection Fix the ems_custom_attributes inventory collection (cherry picked from commit 72021d9)
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jan 10, 2022
…tory_collection Fix the ems_custom_attributes inventory collection (cherry picked from commit 72021d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had a manager_ref of just
:namebut these belong to a polymorphic resource and just the name is not unique.Adding the
:resourceto the manager_ref array makes this unique.Spec test showing the failure: ManageIQ/manageiq-providers-vmware#771
Fixes ManageIQ/manageiq-providers-vmware#727