Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move build/systemd_units/ -> systemd/ due to BUILD file conflict #21122

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Move build/systemd_units/ -> systemd/ due to BUILD file conflict #21122

merged 1 commit into from
Mar 25, 2021

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 25, 2021 •
edited by Fryguy
Loading

Case-insensitive filesystems are failing due to the existence of a BUILD file and a build/ directory.

4: from Code/manageiq/lib/vmdb/initializer.rb:11:in `init'
     3: from Code/manageiq/app/models/miq_server.rb:72:in `starting_server_record'
     2: from Code/manageiq/lib/vmdb/appliance.rb:10:in `BUILD'
     1: from Code/manageiq/lib/vmdb/appliance.rb:150:in `get_build'
Code/manageiq/lib/vmdb/appliance.rb:150:in `read': Is a directory @ io_fread - Code/manageiq/BUILD (Errno::EISDIR)

Provider PRs:

RPM Build:

@agrare
Move build/systemd_units/ -> systemd/ due to BUILD file conflict
3bd1880 
Case-insensitive filesystems are failing due to the existence of a BUILD
file and a build/ directory.
@agrare agrare requested review from Fryguy and gtanzillo as code owners March 25, 2021 14:14
@agrare agrare added the bug label Mar 25, 2021
@Fryguy Fryguy self-assigned this Mar 25, 2021
@jrafanie
Copy link
Member

Case-insensitive filesystems are failing due to the existence of a BUILD file and a build/ directory.

How insensitive of them?

@jrafanie
Copy link
Member

Should this be linked to another PR that handles the rename/collapse from build/systemd_units -> systemd? Is that rpm_build?

@miq-bot
Copy link
Member

miq-bot commented Mar 25, 2021

Checked commit agrare@3bd1880 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare
Copy link
Member Author

agrare commented Mar 25, 2021

Should this be linked to another PR that handles the rename/collapse from build/systemd_units -> systemd? Is that rpm_build?

@jrafanie first step is to rename all the directories (just finished pushing those PRs out, linking them to the description now).

Next step is to change manageiq-rpm_build to look in the new location (haven't gotten to that one yet).

I wanted to push this out asap since you noted that people on macs are currently failing if they have a BUILD file.

@agrare agrare mentioned this pull request Mar 25, 2021
Merged
@jrafanie
Copy link
Member

@jrafanie first step is to rename all the directories (just finished pushing those PRs out, linking them to the description now).

Next step is to change manageiq-rpm_build to look in the new location (haven't gotten to that one yet).

I wanted to push this out asap since you noted that people on macs are currently failing if they have a BUILD file.

cool, I didn't know what sequence of changes would prevent the most test failures

@Fryguy Fryguy merged commit 67acc8c into ManageIQ:master Mar 25, 2021
@agrare agrare deleted the fix_build_dir_name_conflict branch March 25, 2021 14:42
@agrare agrare mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@Fryguy Fryguy

Labels
bug core/workers core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @jrafanie @miq-bot @Fryguy