Avoid seeding ansible content in production

[Fryguy]

Ansible content is already seeded at RPM build time, so to avoid the
need to hit the filesystem again, we should skip this in production
mode.

Additionally, this adds the consolidation of ansible content to seed
time, in addition to the fetching of galaxy roles.

@kbrock @agrare Please review.

Note that the seeding happens at RPM build time here: https://github.com/ManageIQ/manageiq-rpm_build/blob/3173133b27375a26cc205c09d3d3c627e907c635/lib/manageiq/rpm_build/generate_core.rb#L63-L67

[miq-bot]

Some comments on commit Fryguy@6f40eb1

lib/ansible/content.rb

• ⚠️ - 22 - Detected puts. Remove all debugging statements.
• ⚠️ - 25 - Detected puts. Remove all debugging statements.
• ⚠️ - 27 - Detected puts. Remove all debugging statements.

lib/tasks/evm_ansible_runner.rake

• ⚠️ - 11 - Detected puts. Remove all debugging statements.
• ⚠️ - 13 - Detected puts. Remove all debugging statements.
• ⚠️ - 7 - Detected puts. Remove all debugging statements.
• ⚠️ - 9 - Detected puts. Remove all debugging statements.

[Fryguy]

Moving forward we may want to split the seeding task into 2 separate tasks and run them separately at build time (consolidate for core and fetch_galaxy for gemset), but this should be fine for now.

[miq-bot]

Checked commit Fryguy@6f40eb1 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
4 files checked, 3 offenses detected

lib/ansible/content.rb

• ❗ - Line 22, Col 9 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 25, Col 11 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 27, Col 11 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

[Fryguy]

Note the method rename here. This was intentional, as we don't just consolidate playbooks, so the name was inaccurate and confusing.

[kbrock]

this is nice jason

[kbrock]

still feel this would be better suited for /bin/update or /bin/setup

but I'm ok with this

[Fryguy]

yeah, I didn't want to rock this boat too much, so I left it...we can definitely debate dropping it from here, but I'd rather do that in a follow up.

I really don't understand the use case of why it's here in seed in the first place. From what I can tell it's for developers modifying things, but then, I don't see why they can't just call evm:ansible_runner:seed themselves.

[kbrock]

Moving forward we may want to split the seeding task into 2 separate tasks and run them separately at build time (consolidate for core and fetch_galaxy for gemset), but this should be fine for now.

I was hoping we wouldn't need anything in core runtime - only core setup/install