Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace validate_destroy with supports feature #21073

Conversation

@chessbyte chessbyte self-assigned this Feb 22, 2021
@miq-bot
Copy link
Member

miq-bot commented Feb 22, 2021

Checked commit agrare@7cbd2c0 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@chessbyte
Copy link
Member

Does not seem to affect this PR, but need to be careful of hidden calls to validate_#{action} as in here and here

@chessbyte chessbyte merged commit 67e5479 into ManageIQ:master Feb 22, 2021
@agrare agrare deleted the replace_host_validate_destroy_with_supports_feature branch February 22, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants