[WIP] Flatten worker settings

[Fryguy]

This PR flattens the complicated nesting of the worker settings in order to make it easier for end users to find what they are looking for. In particular, since YAML is whitespace delimited, it can be very easy to mess up the yaml nesting, and this should fix that problem. One downside of going from a tree structure to a flat structure is that you lose context of what is inherited. As such, this PR introduces a new key in the settings, :inherited_from which acts more like a comment to the editor and cannot be modified by the end user. However, with that information, they should be able to easily traverse up the inheritance chain to determine the values.

cc @jrafanie

WIP because

• Need more testing
• UI screens will have to compensate for the new format
  • Flatten worker settings manageiq-ui-classic#7599
• Update provider settings
  • Flatten worker settings manageiq-providers-amazon#677
  • Flatten worker settings manageiq-providers-ansible_tower#251
  • Flatten worker settings manageiq-providers-autosde#54
  • Flatten worker settings manageiq-providers-azure#431
  • Flatten worker settings manageiq-providers-azure_stack#55
  • Flatten worker settings manageiq-providers-dummy_provider#32
  • Flatten worker settings manageiq-providers-foreman#83
  • Flatten worker settings manageiq-providers-google#177
  • Flatten worker settings manageiq-providers-ibm_cloud#130
  • Flatten worker settings manageiq-providers-ibm_terraform#57
  • Flatten worker settings manageiq-providers-kubernetes#420
  • Flatten worker settings manageiq-providers-kubevirt#180
  • Flatten worker settings manageiq-providers-lenovo#327
  • Flatten worker settings manageiq-providers-nsxt#33
  • Flatten worker settings manageiq-providers-nuage#239
  • Flatten worker settings manageiq-providers-openshift#202
  • Flatten worker settings manageiq-providers-openstack#684
  • Flatten worker settings manageiq-providers-ovirt#546
  • Flatten worker settings manageiq-providers-redfish#135
  • Flatten worker settings manageiq-providers-scvmm#179
  • Flatten worker settings manageiq-providers-vmware#691
• Data migration needed for existing settings changes
  • Flatten worker settings manageiq-schema#555
• Update documentation - https://github.com/ManageIQ/manageiq-documentation/blame/master/general_configuration/_topics/configuration.md#L1565
• Update guides/architecture/source_code_layout.md
• Update tools/configure_server_settings.rb
• Change downstream overrides

[chessbyte]

good simplification!

[Fryguy]

@miq-bot cross-repo-test /all, ManageIQ/manageiq-ui-classic#7599, ManageIQ/manageiq-providers-amazon#677, ManageIQ/manageiq-providers-ansible_tower#251, ManageIQ/manageiq-providers-autosde#54, ManageIQ/manageiq-providers-azure#431, ManageIQ/manageiq-providers-azure_stack#55, ManageIQ/manageiq-providers-dummy_provider#32, ManageIQ/manageiq-providers-foreman#83, ManageIQ/manageiq-providers-google#177, ManageIQ/manageiq-providers-ibm_cloud#130, ManageIQ/manageiq-providers-ibm_terraform#57, ManageIQ/manageiq-providers-kubernetes#420, ManageIQ/manageiq-providers-kubevirt#180, ManageIQ/manageiq-providers-lenovo#327, ManageIQ/manageiq-providers-nsxt#33, ManageIQ/manageiq-providers-nuage#239, ManageIQ/manageiq-providers-openshift#202, ManageIQ/manageiq-providers-openstack#684, ManageIQ/manageiq-providers-ovirt#546, ManageIQ/manageiq-providers-redfish#135, ManageIQ/manageiq-providers-scvmm#179, ManageIQ/manageiq-providers-vmware#691, ManageIQ/manageiq-schema#555

[miq-bot]

Checked commit Fryguy@d166e42 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
7 files checked, 2 offenses detected

app/models/miq_worker.rb

• ❗ - Line 199, Col 14 - Style/HashEachMethods - Use each_key instead of keys.each.
• ❗ - Line 204, Col 13 - Performance/RegexpMatch - Use match? instead of =~ when MatchData is not used.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[kbrock]

Do we want to still move forward with this?
Or are these changes just too much for us at this time?

[Fryguy]

I still want to move forward with this, but need to rework it, possibly to remove the inheritance entirely. I had spoken to @jrafanie a while back and didn't want to step on the work he was doing to fix the UI form. In that thread we discussed possibly dropping the inheritance entirely, which would mean this PR would stay, but it would be even less complicated.

See ManageIQ/manageiq-ui-classic#7725 (comment)

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.