Remove unused assignments #20879
Merged
Remove unused assignments #20879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits https://github.com/djberg96/manageiq/compare/8956fc97ca5f5ab2923647aa11bdcae1296e61e7~...3715bb7fed412b011095b4bee9758212953958d3 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Fryguy
reviewed
Dec 8, 2020
| @@ -50,7 +50,6 @@ def encrypt_queue_params(params) | |||
| end | |||
|
|
|||
| def create_in_provider_queue(manager_id, params, auth_user = nil) | |||
| manager = parent.find(manager_id) | |||
There was a problem hiding this comment.
Yeah @djberg96 posted about this on gitter this morning [ref], 34eac12#diff-5d49121ce998251e7bee6e65be3367227fc6caddb651caa82f198a188458de73L56 removed the use of manager.my_zone so this lookup isn't necessary anymore
|
The rest LGTM - just want @agrare to eyeball the one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the rubocop linter revealed the following unused assignments in app/models. This PR cleans them.