Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display names for FileDepot models #20863

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Add display names for FileDepot models #20863

merged 1 commit into from
Dec 8, 2020

Conversation

mzazrivec
Copy link
Contributor

@miq-bot add_label internationalization

@mzazrivec mzazrivec requested a review from NickLaMuro as a code owner December 3, 2020 16:37
NickLaMuro
NickLaMuro approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@NickLaMuro NickLaMuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the def display_name(number = 1 is a standard of some sort for i18n in our project, since we seem to have it else where. So this seems good to me.

Looks like code! 🐑 🇮🇹

@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2020

Checked commit mzazrivec@9dc69fc with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@bdunne bdunne merged commit df55f40 into ManageIQ:master Dec 8, 2020
@bdunne bdunne self-assigned this Dec 8, 2020
@bdunne bdunne added the core label Dec 8, 2020
@mzazrivec mzazrivec deleted the add_display_names_for_file_depots branch December 8, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLaMuro NickLaMuro NickLaMuro approved these changes

@Fryguy Fryguy Fryguy approved these changes

Assignees

@bdunne bdunne

Labels
core internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzazrivec @miq-bot @Fryguy @NickLaMuro @bdunne