Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup a useless next unless in worker monitor #20862

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 3, 2020

There used to be a sync config action after the validate_worker method that was removed so the next unless is pointless now.

Removed by: https://github.com/ManageIQ/manageiq/pull/19666/files#diff-4a1cee6eab58de0540a89bab68b4d15c6e411dca2b538b28715641069a2679d0L35-L36

There used to be a sync config action after the validate_worker method
that was removed so the next unless is pointless now.
@miq-bot
Copy link
Member

miq-bot commented Dec 3, 2020

Checked commit agrare@61282a3 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie jrafanie merged commit 0575f8b into ManageIQ:master Dec 3, 2020
@agrare agrare deleted the fix_useless_next_unless_worker_validate branch December 3, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants