Auto-restart systemd workers results in duplicates #20824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the worker GUID is part of the systemd service when a systemd worker is restarted by systemd it will get a new PID but reuse the old GUID. If MiqServer deletes the worker row because it doesn't see the PID then you end up with a service restarting and failing to find its row constantly.
|
I don't like where we write these files out, I'd prefer we write them once on startup and move on. Going to tackle that then take this out of WIP. |
agrare
force-pushed
the
dont_restart_systemd_worker_automatically
branch
from
08d5894 to
4b54bce
Compare
agrare
commented
Nov 18, 2020
agrare
changed the title
jrafanie
reviewed
Nov 19, 2020
jrafanie
reviewed
Nov 19, 2020
jrafanie
reviewed
Nov 19, 2020
When the systemd worker option was first introduced as a prototype there was a setting that would control if systemd or the normal forking worker mode was used. This setting was per worker, and was done in sync_workers so that you could change the setting "on-the-fly" without restarting the entire evmserverd process. This made it much easier to try out using systemd on one or two workers very quickly. Now that systemd is the default for appliances the ability to change this dynamically isn't very helpful, and writing out systemd unit files during sync_workers is just a lot of overhead. Moving the writing of systemd unit files to miq_server startup removes the overhead per-sync_workers-loop and allows us to update the contents of the files without checking .exist? (which was done due to the frequency with which it was being run).
agrare
force-pushed
the
dont_restart_systemd_worker_automatically
branch
from
532a99d to
d215045
Compare
|
Checked commits agrare/manageiq@b734fad~...d215045 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
@jrafanie are you waiting on something/someone before merging? |
Just travis...it's green now, thanks for the ping |
simaishi
pushed a commit
that referenced
this pull request
Nov 19, 2020
…omatically Auto-restart systemd workers results in duplicates (cherry picked from commit 2f8ae23)
|
Kasparov backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the worker GUID is part of the systemd service when a systemd worker is restarted by systemd it will get a new PID but reuse the old GUID.
If MiqServer deletes the worker row because it doesn't see the PID then you end up with a service restarting and failing to find its row constantly.
Fixes #20822