Ensure that options[:ems_id] is an Array when passed as an ENV var #20809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
reviewed
Nov 12, 2020
When passing the EMS_ID as an ENV var we need to ensure that it is an array to be consistent with how OptionParser is processing it
agrare
force-pushed
the
fix_ems_workers_ems_id_non_array
branch
from
34ce23d to
5b609bb
Compare
|
Checked commit agrare@5b609bb with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
@gtanzillo @jrafanie can we mark this |
Yes. 💯 |
|
cc @simaishi |
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2020
Ensure that options[:ems_id] is an Array when passed as an ENV var (cherry picked from commit 8ac612f)
|
Kasparov backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing the EMS_ID as an ENV var we need to ensure that it is an array to be consistent with how OptionParser is processing it
Longer term we should be able to drop EMS_ID as an array now that #20345 is passing the parent manager ems_id only for the queue_name.