Update the Ansible::Runner wait_for timeout #20674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
commented
Oct 8, 2020
agrare
force-pushed
the
update_runner_wait_for_timeout
branch
2 times, most recently
from
3c954ed to
bf0a2d6
Compare
Fryguy
reviewed
Oct 8, 2020
lib/ansible/runner.rb
Outdated
| @@ -218,7 +218,7 @@ def run_via_cli(hosts, credentials, env_vars, extra_vars, tags: nil, ansible_run | |||
| fetch_galaxy_roles(playbook_or_role_args) | |||
|
|
|||
| result = wait_for(pid_file(base_dir)) do | |||
| AwesomeSpawn.run("ansible-runner", :env => env_vars_hash, :params => params) | |||
| AwesomeSpawn.run!("ansible-runner", :env => env_vars_hash, :params => params) | |||
There was a problem hiding this comment.
If i recall, this didn't use ! on purpose because of some weird cases where it returns 1 as a "good" return value.
There was a problem hiding this comment.
Hm okay, let me just update the timeout to match jansa and we can see if there's a better way to do this in a follow-up
Drop the wait_for timeout to 10 seconds
agrare
force-pushed
the
update_runner_wait_for_timeout
branch
from
bf0a2d6 to
d071f33
Compare
|
Checked commit agrare@d071f33 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the wait_for timeout to 10 seconds to match what has been merged to
jansain #20670