add ancestry case to the genealogy parent setter #20642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-u
changed the title
d-m-u
force-pushed
the
improving_genealogy_parent_setter
branch
from
5d97e98 to
677dac3
Compare
|
this code is good. In this context, the relationships array is confusing as to what it even is. I think this should build on the pr that establishes relationship types and has the call ancestry or other. then the PR that is trying to get vms working will do this change. |
d-m-u
force-pushed
the
improving_genealogy_parent_setter
branch
from
677dac3 to
7750cd9
Compare
d-m-u
changed the title
|
could I please get this |
when we destroy all relationships, we'll want to alias this setter to parent=
d-m-u
force-pushed
the
improving_genealogy_parent_setter
branch
from
7750cd9 to
528509b
Compare
|
Checked commit d-m-u@528509b with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the multiplicity of tree like structures and their differences in behavior makes this overly complicated. we've got a few bugs with multiple parents being set and a lot of code written to address that bug in particular. we're trying to simplify all this by removing relationships.
this genealogy_parent setter needs to eventually handle ancestry cases as well.
when we destroy all relationships, we'll want to just alias this to
parent=@miq-bot assign @kbrock
relies on
#20274
for the
use_ancestry?method