[EmbeddedAnsible] Fix edit credentials

[NickLaMuro]

Fixes ManageIQ/manageiq-ui-classic#7286

There was a bug when editing credentials for EmbeddedAnsible where if you edited an attribute and there are other attributes on the particular credential class' params_to_attributes method which have to be converted, those previously would be nil'd out.

This fixes that, and modifies tests to confirm that this is now working.

Links

• Original BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1869885
• Original Issue: Editing username for EmbeddedAnsible SCM credential cause key to be nil'd out manageiq-ui-classic#7286
• Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1881513 (ivanchuk)

[Fryguy]

❗ - Line 93, Col 36 - Layout/BlockAlignment - end at 93, 35 is not aligned with previous_params_to_attrs = params_to_attrs.each_with_object({}) do |key, attrs| at 91, 8.

Wow! Pretty sure that's a rubocop bug. Its detecting the alignment to the middle of the previous_params_to_attrs because it happens to end in the same string params_to_attrs 😮

I wonder if that happens with a newer rubocop.

[Fryguy]

The rubocops in app/models/manageiq/providers/embedded_ansible/automation_manager/openstack_credential.rb should be fixed cause they are actually misaligned. Same with "Redundant curly braces around a hash parameter.". The rest I think are on unrelated lines.

[miq-bot]

Checked commit NickLaMuro@7bbdf70 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
10 files checked, 1 offense detected

spec/models/manageiq/providers/embedded_ansible/automation_manager/credential_spec.rb

• ❗ - Line 93, Col 36 - Layout/BlockAlignment - end at 93, 35 is not aligned with previous_params_to_attrs = params_to_attrs.each_with_object({}) do |key, attrs| at 91, 8.

[NickLaMuro]

@Fryguy I assume you are good with this now that the Rubocop errors are fixed, right?

[simaishi]

Jansa backport details:

$ git log -1
commit 3801f07425471006e6ce1c87fa913410a6795146
Author: Jason Frey <[email protected]>
Date:   Thu Sep 10 18:17:07 2020 -0400

    Merge pull request #20524 from NickLaMuro/fix-embedded-ansible-credential-editing

    [EmbeddedAnsible] Fix edit credentials

    (cherry picked from commit 9a23708582de38c9ae0cc8332f7e46fc1a53ba08)

[tinaafitz]

Hi @NickLaMuro Can this be ivanchuk/yes?

[NickLaMuro]

@tinaafitz yeah, that would be fine. Just slipped my mind on that one.

@miq-bot add_label ivanchuk/yes

[simaishi]

Ivanchuk backport details:

$ git log -1
commit c0f0eeec8ee112370ea41444806d655c4d1990f1
Author: Jason Frey <[email protected]>
Date:   Thu Sep 10 18:17:07 2020 -0400

    Merge pull request #20524 from NickLaMuro/fix-embedded-ansible-credential-editing

    [EmbeddedAnsible] Fix edit credentials

    (cherry picked from commit 9a23708582de38c9ae0cc8332f7e46fc1a53ba08)

    https://bugzilla.redhat.com/show_bug.cgi?id=1881513