Replace MiqUUID with Digest::UUID #20403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/djberg96/manageiq/commit/ad04a529ba970f6a2a027107dd92a0279ec33ca2 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Fryguy
requested changes
Jul 31, 2020
Fryguy
approved these changes
Jul 31, 2020
|
@Fryguy Is the failure related? I wouldn't think so. |
|
@djberg96 should be resolved by ManageIQ/manageiq-providers-lenovo#309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to ManageIQ/more_core_extensions#81, where we added
Digest::UUID.cleanin an effort to ultimately removeMiqUUID.clean_guidfrom gems-pending.Since
more_core_extensionsversioning is now handled via gems-pending, and that was bumped to 4.0 in ManageIQ/manageiq-gems-pending#481, it should be safe to replace this.